Re: [OE-core][PATCH 2/2] convert-overrides.py: skip patches

["Chen Qi" <Qi.Chen@windriver.com>]

On 08/06/2021 06:58 PM, Richard Purdie wrote:
> On Fri, 2021-08-06 at 02:03 -0700, Chen Qi wrote:
>> If a line specifies a patch, skip it.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   scripts/contrib/convert-overrides.py | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/scripts/contrib/convert-overrides.py b/scripts/contrib/convert-overrides.py
>> index 4d41a4c475..387e29d66d 100755
>> --- a/scripts/contrib/convert-overrides.py
>> +++ b/scripts/contrib/convert-overrides.py
>> @@ -63,6 +63,7 @@ skips = skips + ["run_loaddata_poky", "determine_if_poky_env", "do_populate_poky
>>   skips = skips + ["get_appends_for_files", "test_doubleref_remove", "test_bitbakelayers_add_remove", "elf32_x86_64", "colour_remove", "revmap_remove"]
>>   skips = skips + ["test_rpm_remove", "test_bitbakelayers_add_remove", "recipe_append_file", "log_data_removed", "recipe_append", "systemd_machine_unit_append"]
>>   skips = skips + ["recipetool_append", "changetype_remove", "try_appendfile_wc", "test_qemux86_directdisk", "test_layer_appends", "tgz_removed"]
>> +skips = skips + ["file://"]
> This is never simple since this would now skip:
>
> SRC_URI_append = " file://xxxx"

I didn't realize such case. Thanks for pointing it out.

Regards,
Qi

>
> I'm not sure which issue is better/worse...
>
> Cheers,
>
> Richard
>
>
>