Re: [OE-core][PATCH 1/2] convert-overrides.py: also convert comments without a leading whitespace

["Chen Qi" <Qi.Chen@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 2896 bytes --]

Got it. I've sent out V2.

Regards,
Qi

On 08/06/2021 05:25 PM, Martin Jansa wrote:
> Can you please bump the script version as well?
>
> On Fri, Aug 6, 2021 at 11:03 AM Chen Qi <Qi.Chen@windriver.com 
> <mailto:Qi.Chen@windriver.com>> wrote:
>
>     Currently lines like below are converted.
>       e.g.
>       # IMAGE_INSTALL_append = " A"
>
>     But lines without a leading whitespace are not converted.
>       e.g.
>       #IMAGE_INSTALL_append = " A"
>
>     We should be converting both.
>
>     Signed-off-by: Chen Qi <Qi.Chen@windriver.com
>     <mailto:Qi.Chen@windriver.com>>
>     ---
>      scripts/contrib/convert-overrides.py
>     <https://urldefense.com/v3/__http://convert-overrides.py__;%21%21AjveYdw8EvQ%21PD0spdg2c_3A47Id6ecejSLJcClzE1tewbyquzswai_YYcg_XxOQyX2l9AH3cc9f2A$>
>     | 6 +++---
>      1 file changed, 3 insertions(+), 3 deletions(-)
>
>     diff --git a/scripts/contrib/convert-overrides.py
>     <https://urldefense.com/v3/__http://convert-overrides.py__;%21%21AjveYdw8EvQ%21PD0spdg2c_3A47Id6ecejSLJcClzE1tewbyquzswai_YYcg_XxOQyX2l9AH3cc9f2A$>
>     b/scripts/contrib/convert-overrides.py
>     <https://urldefense.com/v3/__http://convert-overrides.py__;%21%21AjveYdw8EvQ%21PD0spdg2c_3A47Id6ecejSLJcClzE1tewbyquzswai_YYcg_XxOQyX2l9AH3cc9f2A$>
>     index e4a310d1d6..4d41a4c475 100755
>     --- a/scripts/contrib/convert-overrides.py
>     <https://urldefense.com/v3/__http://convert-overrides.py__;%21%21AjveYdw8EvQ%21PD0spdg2c_3A47Id6ecejSLJcClzE1tewbyquzswai_YYcg_XxOQyX2l9AH3cc9f2A$>
>     +++ b/scripts/contrib/convert-overrides.py
>     <https://urldefense.com/v3/__http://convert-overrides.py__;%21%21AjveYdw8EvQ%21PD0spdg2c_3A47Id6ecejSLJcClzE1tewbyquzswai_YYcg_XxOQyX2l9AH3cc9f2A$>
>     @@ -69,15 +69,15 @@ packagevars = packagevars + imagevars
>
>      vars_re = {}
>      for exp in vars:
>     -    vars_re[exp] =
>     (re.compile('((^|[\'"\s\-\+])[A-Za-z0-9_\-:${}\.]+)_' + exp),
>     r"\1:" + exp)
>     +    vars_re[exp] =
>     (re.compile('((^|[#\'"\s\-\+])[A-Za-z0-9_\-:${}\.]+)_' + exp),
>     r"\1:" + exp)
>
>      shortvars_re = {}
>      for exp in shortvars:
>     -    shortvars_re[exp] =
>     (re.compile('((^|[\'"\s\-\+])[A-Za-z0-9_\-:${}\.]+)_' + exp +
>     '([\(\'"\s:])'), r"\1:" + exp + r"\3")
>     +    shortvars_re[exp] =
>     (re.compile('((^|[#\'"\s\-\+])[A-Za-z0-9_\-:${}\.]+)_' + exp +
>     '([\(\'"\s:])'), r"\1:" + exp + r"\3")
>
>      package_re = {}
>      for exp in packagevars:
>     -    package_re[exp] = (re.compile('(^|[\'"\s\-\+]+)' + exp + '_'
>     + '([$a-z"\'\s%\[<{\\\*].)'), r"\1" + exp + r":\2")
>     +    package_re[exp] = (re.compile('(^|[#\'"\s\-\+]+)' + exp + '_'
>     + '([$a-z"\'\s%\[<{\\\*].)'), r"\1" + exp + r":\2")
>
>      # Other substitutions to make
>      subs = {
>     -- 
>     2.30.2
>
>
>     
>


[-- Attachment #2: Type: text/html, Size: 4620 bytes --]