Re: [OE-core] [PATCH] cargo: Increase RUST_MIN_STACK size to avoid SIGSEGV in DEBUG builds only.

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2024-11-14 at 16:32 +0530, Yash Shinde via lists.openembedded.org wrote:
> 
> On 31-10-2024 19:32, Randy MacLeod wrote:
> > 
> > We discussed this issue and agreed that since it doesn't affect YP AB 
> > since there are no DEBUG builds done there
> > and more importantly since it's really a work-around rather than a 
> > fix, we'll continue to work with upstream p384
> > crate owners to resolve the issue. Forcing users to change the stack 
> > size, even for debug builds, is not a good policy
> > and hopefully some of the code-generation tools that are inputs to 
> > p384 can be adjusted to reduce stack usage.
> > 
> > ../Randy
> > 
> This issue is now fixed by removing unused mut variables in p384 crate 
> and thus reducing the codegen.
> (https://github.com/RustCrypto/elliptic-curves/commit/7652c5842cde60acc1e739ebbba34614cb158f8b)
> 
> The current stable version of the RustCrypto  p384 crate is v0.13.0, 
> which is also the default version for building with Rust.
> But, the fix has been merged into the pre-release versions 
> "p384/v0.14.0-pre.2" and "p384/v0.14.0-pre.1." of p384 crate.
> 
> I have opened a discussion thread in p384 crate: 
> https://github.com/RustCrypto/elliptic-curves/discussions/1102
> to ask the crate developers either to update p384 crate into new version 
> with the fix, or backport it to "v.0.13.0".
> 
> We can wait for upstream unless someone wants to merge a patch for 
> master now. Let me know your thoughts on this.

Firstly, big thanks for working through this. Getting issues like this
fixed at source in the upstream is infinitely preferable to carrying
weird workarounds.

I think it should be fine to wait for the upstream change to filter
through to us?

Cheers,

Richard