public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] base: make feature backfilling happen earlier
Date: Mon, 28 Jan 2013 17:23:40 +0100	[thread overview]
Message-ID: <lywquxjmyb.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw)
In-Reply-To: <1440434.Jn4S7oh0Xd@helios> (Paul Eggleton's message of "Mon, 28 Jan 2013 15:58:04 +0000")

Paul Eggleton <paul.eggleton@linux.intel.com> writes:

>> 1. set some defaults on distribution base ...
>> 2. allow to override these defaults on a per-project base
>> ...
>> afaik, DISTRO_FEATURES_BACKFILL + _CONSIDERED exist to allow the first
>> two point without an '-=' operator which lacks in bitbake.
>
> No they don't. They exist to allow adding new features that should be enabled 
> for all existing distro configs without each of those having to be changed, and 
> provide a means for distros to opt out of that enabling if they wish.

How is this different from my requirements?  Ok; atm,
DISTRO_FEATURES_BACKFILL is pretty useless because it contains only
'pulseaudio' which is probably unwanted on >90% of all embedded devices
and it is impossible to extend DISTRO_FEATURES_BACKFILL.

But this variable exists to allow removal of features which are enabled
by default.


>> Of course, I could reinvent the wheel and write my own _CONSIDERED
>> mechanism.  But until now (resp. without the '=' => '?=' change), it
>> worked fine with DISTRO_FEATURES_BACKFILL.
> ...
> It's still not clear to me why you could not just set DISTRO_FEATURES
> directly. If you have values you're likely to want to remove, you can
> put them in separate variables that you can clear out later.

It is very difficultly to do within distro.conf. E.g. having

| DISTRO_FEATURES = "${@subtract_set('DISTRO_FEATURES', 'UNWANTED_FEATURES')}'

will probably result into some error regarding recursive expansion.

Using ':=' will not work here because required operations are not
available yet.


At the end it will reinvent the DISTRO_FEATURES_BACKFILL_CONSIDERED
wheel by moving it into my-distro.bbclass.



Enrico



  reply	other threads:[~2013-01-28 16:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24 17:52 [PATCH 0/2] DISTRO_FEATURES compatibility fixes Ross Burton
2013-01-24 17:52 ` [PATCH 1/2] bitbake.conf: unbreak all builds with custom DISTRO_FEATURES Ross Burton
2013-01-24 17:52 ` [PATCH 2/2] base: make feature backfilling happen earlier Ross Burton
2013-01-25 18:06   ` Enrico Scholz
2013-01-28 12:54     ` Richard Purdie
2013-01-28 13:55       ` Enrico Scholz
2013-01-28 14:19         ` Paul Eggleton
2013-01-28 14:52           ` Enrico Scholz
2013-01-28 15:00             ` Phil Blundell
2013-01-28 15:44               ` Enrico Scholz
2013-01-28 15:58                 ` Paul Eggleton
2013-01-28 16:23                   ` Enrico Scholz [this message]
2013-01-28 16:34                     ` Paul Eggleton
2013-01-29 11:07                       ` Enrico Scholz
2013-01-28 16:15                 ` Phil Blundell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=lywquxjmyb.fsf@ensc-virt.intern.sigma-chemnitz.de \
    --to=enrico.scholz@sigma-chemnitz.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox