Feedback for patch adding softsqueeze recipe

Feedback for patch adding softsqueeze recipe

[Jaya Kumar]

Hi,

I had submited a patch adding a recipe for softsqueeze. This is under bug 1717.
http://bugs.openembedded.org/show_bug.cgi?id=1717

I would welcome your advice and feedback if it is ok before I try
doing other stuff.

Thanks,
jaya

Re: Feedback for patch adding softsqueeze recipe

[Richard Purdie]

Hi,

On Sat, 2006-12-30 at 23:25 -0500, Jaya Kumar wrote:
> I had submited a patch adding a recipe for softsqueeze. This is under bug 1717.
> http://bugs.openembedded.org/show_bug.cgi?id=1717
> 
> I would welcome your advice and feedback if it is ok before I try
> doing other stuff.

Hmm. You didn't pick a very easy package to build ;-). Firstly, this .bb
file doesn't build softsqueeze, it builds squeezeslave which is
something different. I was wondering since softsqueeze is a java app... 

Style wise I did wonder why you used "DEPENDS +=" ? Its not wrong as
such but not the usual style. I also didn't like the sed magic for
makefile.linux. I've changed that to use a patch because its easier to
see whats going on and if upstream changes, you will be more likely to
see the change when the patch fails to apply. Also, when you do this,
you find you patched $(LDFLAGS) into "make clean" and some other places
it isn't needed ;-).

I totally agree with using OE's own flac, vorbis and ogg libs. I'd go
further and add portaudio to OE as a separate package too. I'd also like
to see libslimproto packaged as a separate package and dynamically
linked to.

I'll add a version that implements some of the above to OE.dev shortly
(access to the server appears to be broken atm). Perhaps you could look
at sorting out a proper portaudio package?

I tried running the package on ARM and found a bug that stopped the
program running. I've not tested much more that this as I don't have
working sound on the device atm.

Its nice to see someone looking at using the Slim Devices software in
OE. I did some hacking on SlimServer and wrote the protocol information
softsqueeze was based on a few years ago :)

Richard