From: Phil Blundell <philb@gnu.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [RFC] fix for MACHINE_KERNEL_PR stuff
Date: Wed, 03 Jun 2009 13:32:21 +0100 [thread overview]
Message-ID: <1244032341.2611.53.camel@mill.internal.reciva.com> (raw)
In-Reply-To: <200906031325.48159.marcin@juszkiewicz.com.pl>
On Wed, 2009-06-03 at 13:25 +0200, Marcin Juszkiewicz wrote:
> This patch unbreaks current behaviour which was introduced by
> MACHINE_KERNEL_PR variable.
>
> As most of target machines do not use it they have PR with broken value
> (set to "r0" instead of value in recipe). I took other way which makes
> both types of users happy -- those with MACHINE_KERNEL_PR in use and
> those without it.
>
> By default we set M_K_PR to empty string instead of "r0" - this allows
> to check is it set at all or not. If it is set then we set PR to this value.
> Otherwise we ignore existance of that variable and use PR from recipe.
Thanks for the patch. This does look like a reasonable compromise: as
you say, it should prevent MACHINE_KERNEL_PR causing trouble for those
people who don't want it. So, +1 from me.
p.
next prev parent reply other threads:[~2009-06-03 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 11:25 [RFC] fix for MACHINE_KERNEL_PR stuff Marcin Juszkiewicz
2009-06-03 11:45 ` Koen Kooi
2009-06-03 11:59 ` Marcin Juszkiewicz
2009-06-08 17:51 ` Koen Kooi
2009-06-03 12:32 ` Phil Blundell [this message]
2009-06-08 15:54 ` Marcin Juszkiewicz
2009-06-09 4:05 ` Rolf Leggewie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244032341.2611.53.camel@mill.internal.reciva.com \
--to=philb@gnu.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox