Re: [RFC] fix for MACHINE_KERNEL_PR stuff

[Koen Kooi <k.kooi@student.utwente.nl>]

On 03-06-09 13:25, Marcin Juszkiewicz wrote:
>
> This patch unbreaks current behaviour which was introduced by
> MACHINE_KERNEL_PR variable.
>
> As most of target machines do not use it they have PR with broken value
> (set to "r0" instead of value in recipe). I took other way which makes
> both types of users happy -- those with MACHINE_KERNEL_PR in use and
> those without it.
>
> By default we set M_K_PR to empty string instead of "r0" - this allows
> to check is it set at all or not. If it is set then we set PR to this value.
> Otherwise we ignore existance of that variable and use PR from recipe.
>
> Please test and review it. If this will work I will request it for stable/2009.
>
> Signed-off-by: Marcin Juszkiewicz<marcin@juszkiewicz.com.pl>
>
> diff --git a/classes/kernel.bbclass b/classes/kernel.bbclass
> index 1323228..757b704 100644
> --- a/classes/kernel.bbclass
> +++ b/classes/kernel.bbclass
> @@ -20,6 +20,12 @@ python __anonymous () {
>       image = bb.data.getVar('INITRAMFS_IMAGE', d, True)
>       if image != '' and image is not None:
>           bb.data.setVar('INITRAMFS_TASK', '${INITRAMFS_IMAGE}:do_rootfs', d)
> +
> +    pr = bb.data.getVar('PR', d, True)

You're not using 'pr' anywhere in the code you add. Looks fine 
otherwise, although I haven't tested it.

regards,

Koen