From: Khem Raj <raj.khem@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [PATCH, V2 4/6] cross.bbclass, staging.bbclass, utils.bbclass: Make sure that .la munging is not done for libtool > 2.4
Date: Wed, 6 Oct 2010 18:46:09 -0700 [thread overview]
Message-ID: <1286415971-9960-5-git-send-email-raj.khem@gmail.com> (raw)
In-Reply-To: <1286415971-9960-1-git-send-email-raj.khem@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
classes/cross.bbclass | 7 +++----
classes/staging.bbclass | 19 ++++++++++---------
classes/utils.bbclass | 2 +-
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/classes/cross.bbclass b/classes/cross.bbclass
index d3b27e6..1a6d906 100644
--- a/classes/cross.bbclass
+++ b/classes/cross.bbclass
@@ -74,8 +74,7 @@ sysroot_stage_all() {
}
#
-# Cross .la files have more path issues we have to correct
-SYSROOTEXTRALIBDIRSED = '-e "/^libdir=/s,.*,libdir=${STAGING_DIR_TARGET}${target_libdir},g" \
- -e "/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g" \
-'
+# Cross .la files have more path issues we have to correct only for libtool < 2.4
+SYSROOTEXTRALIBDIRSED_OLD = " -e \"/^libdir=/s,.*,libdir=${STAGING_DIR_TARGET}${target_libdir},g\" -e \"/^dependency_libs=/s,\([[:space:]']\)-L${STAGING_LIBDIR_NATIVE},,g\""
+SYSROOTEXTRALIBDIRSED = "${@["${SYSROOTEXTRALIBDIRSED_OLD}",""][("${LIBTOOL_HAS_SYSROOT}" == "yes")]}"
diff --git a/classes/staging.bbclass b/classes/staging.bbclass
index 303f74c..3f4ff8c 100644
--- a/classes/staging.bbclass
+++ b/classes/staging.bbclass
@@ -42,20 +42,21 @@ SYSROOTEXTRALIBDIRSED ?= ""
sysroot_stage_libdir() {
src="$1"
dest="$2"
-
- olddir=`pwd`
- cd $src
- las=$(find . -name \*.la -type f)
- cd $olddir
- echo "Found la files: $las"
- for i in $las
- do
+ if [ "${LIBTOOL_HAS_SYSROOT}" = "no" ]; then
+ olddir=`pwd`
+ cd $src
+ las=$(find . -name \*.la -type f)
+ cd $olddir
+ echo "Found la files: $las"
+ for i in $las
+ do
sed -e 's/^installed=yes$/installed=no/' \
-e '/^dependency_libs=/s,${WORKDIR}[[:alnum:]/\._+-]*/\([[:alnum:]\._+-]*\),${STAGING_LIBDIR}/\1,g' \
-e "/^dependency_libs=/s,\([[:space:]']\)${libdir},\1${STAGING_LIBDIR},g" \
${SYSROOTEXTRALIBDIRSED} \
-i $src/$i
- done
+ done
+ fi
sysroot_stage_dir $src $dest
}
diff --git a/classes/utils.bbclass b/classes/utils.bbclass
index 61f3731..f7d6996 100644
--- a/classes/utils.bbclass
+++ b/classes/utils.bbclass
@@ -369,7 +369,7 @@ oe_libinstall() {
__runcmd install -m 0644 $dota $destpath/
fi
if [ -f "$dotlai" -a -n "$libtool" ]; then
- if test -n "$staging_install"
+ if [ -n "$staging_install" -a "${LIBTOOL_HAS_SYSROOT}" = "no" ]
then
# stop libtool using the final directory name for libraries
# in staging:
--
1.7.1
next prev parent reply other threads:[~2010-10-07 1:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 1:46 [PATCH,V2 0/6] libtool 2.4 upgrade Khem Raj
2010-10-07 1:46 ` [PATCH,V2 1/6] libtool-2.4: Add recipes for libtool 2.4 Khem Raj
2010-10-07 1:46 ` [PATCH,V2 2/6] bitbake.conf: Define LIBTOOL_HAS_SYSROOT Khem Raj
2010-10-07 1:46 ` [PATCH, V2 3/6] autotools.bbclass: Conditionally use autotools_prepackage_lamangler Khem Raj
2010-10-07 1:46 ` Khem Raj [this message]
2010-10-07 1:46 ` [PATCH, V2 5/6] insane.bbclass: If LIBTOOL_HAS_SYSROOT is set then do not check for la insanity Khem Raj
2010-10-07 1:46 ` [PATCH, V2 6/6] gnutls_2.10.1.bb: Update to libtools 2.4 macros Khem Raj
2010-10-07 7:56 ` [PATCH,V2 0/6] libtool 2.4 upgrade Koen Kooi
2010-10-07 18:31 ` Khem Raj
2010-10-07 22:56 ` Graham Gower
2010-10-07 23:16 ` Graham Gower
2010-10-08 20:48 ` Frans Meulenbroeks
2010-10-08 22:21 ` Chris Larson
2010-10-09 10:37 ` Koen Kooi
2010-10-09 11:37 ` Martin Jansa
2010-10-09 14:31 ` Khem Raj
2010-10-09 15:15 ` Koen Kooi
2010-10-09 16:45 ` Frans Meulenbroeks
2010-10-11 13:13 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286415971-9960-5-git-send-email-raj.khem@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox