From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Cc: richard.purdie@linuxfoundation.org,
openembedded-devel@lists.openembedded.org
Subject: [RFC PATCH] base.bbclass: Deprecate the PRINC logic
Date: Wed, 29 May 2013 08:51:36 -0500 [thread overview]
Message-ID: <1369835496-20815-1-git-send-email-mark.hatle@windriver.com> (raw)
Background:
At the recent TSC meeting we were discussing ways of removing the PRINC
in favor of the PR server, which should now be standard. The first step
in this process is coming up with a simple patch that declared PRINC as
deprecated. If this type of patch is successful, the block of code could
be replaced with a bb.error eventually.
It is not expected that this patch will go in by itself, but instead
should be coordinated with changes to the recipes in common layers such
as openembedded-core, meta-openembedded/meta-* and other community layers.
The commit message follows:
The PRINC logic is now deprecated, the PR server should be used to handle
the automatic incrementing of the PR (package release) field.
A warning message has been added when princ is defined as anything but '0'.
The default setting of '0' has been retained as some layers use embedded
python to increment the PRINC filed. This fails if the base PRINC is not
defined.
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
meta/classes/base.bbclass | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index b1642a2..29084a2 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -465,8 +465,12 @@ python () {
appendVar('EXTRA_OECONF', extraconf)
# If PRINC is set, try and increase the PR value by the amount specified
+ # The PR server is now the preferred way to handle PR changes based on
+ # the checksum of the recipe (including bbappend). The PRINC is now
+ # obsolete. Return a warning to the user.
princ = d.getVar('PRINC', True)
if princ and princ != "0":
+ bb.warn("Use of PRINC is deprecated. The PR server should be used to automatically increment the PR. See: https://wiki.yoctoproject.org/wiki/PR_Service"
pr = d.getVar('PR', True)
pr_prefix = re.search("\D+",pr)
prval = re.search("\d+",pr)
--
1.8.1.2.545.g2f19ada
next reply other threads:[~2013-05-29 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 13:51 Mark Hatle [this message]
2013-05-29 14:11 ` [RFC PATCH] base.bbclass: Deprecate the PRINC logic Richard Purdie
2013-05-29 14:37 ` Martin Jansa
2013-05-29 14:47 ` Richard Purdie
2013-05-29 17:00 ` [OE-core] " Otavio Salvador
2013-05-29 21:24 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369835496-20815-1-git-send-email-mark.hatle@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=openembedded-devel@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox