Re: [RFC PATCH] base.bbclass: Deprecate the PRINC logic

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2013-05-29 at 08:51 -0500, Mark Hatle wrote:
> Background:
> 
> At the recent TSC meeting we were discussing ways of removing the PRINC
> in favor of the PR server, which should now be standard.  The first step
> in this process is coming up with a simple patch that declared PRINC as
> deprecated.  If this type of patch is successful, the block of code could
> be replaced with a bb.error eventually.
> 
> It is not expected that this patch will go in by itself, but instead
> should be coordinated with changes to the recipes in common layers such
> as openembedded-core, meta-openembedded/meta-* and other community layers.
> 
> The commit message follows:
> 
> The PRINC logic is now deprecated, the PR server should be used to handle
> the automatic incrementing of the PR (package release) field.
> 
> A warning message has been added when princ is defined as anything but '0'.
> 
> The default setting of '0' has been retained as some layers use embedded
> python to increment the PRINC filed.  This fails if the base PRINC is not
> defined.
> 
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> ---
>  meta/classes/base.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index b1642a2..29084a2 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -465,8 +465,12 @@ python () {
>              appendVar('EXTRA_OECONF', extraconf)
>  
>      # If PRINC is set, try and increase the PR value by the amount specified
> +    # The PR server is now the preferred way to handle PR changes based on
> +    # the checksum of the recipe (including bbappend).  The PRINC is now
> +    # obsolete.  Return a warning to the user.
>      princ = d.getVar('PRINC', True)
>      if princ and princ != "0":
> +        bb.warn("Use of PRINC is deprecated.  The PR server should be used to automatically increment the PR.  See: https://wiki.yoctoproject.org/wiki/PR_Service"

There is a missing ")" here.

Cheers,

Richard

>          pr = d.getVar('PR', True)
>          pr_prefix = re.search("\D+",pr)
>          prval = re.search("\d+",pr)