[PATCH] gpsd: Fix build when static libs disabled

[PATCH] gpsd: Fix build when static libs disabled

[Maxin B. John]

Fix this build error:
SCons Error: no such option: --disable-static

Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
 meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
index ff268b3..a300595 100644
--- a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
+++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
@@ -47,6 +47,7 @@ EXTRA_OESCONS = " \
     systemd='${SYSTEMD_OESCONS}' \
     ${EXTRA_OECONF} \
 "
+DISABLE_STATIC = ""
 # this cannot be used, because then chrpath is not found and only static lib is built
 # target=${HOST_SYS}
 
-- 
2.4.0

[PATCH] gpsd: Fix build when static libs disabled‏

[Chris Trobridge]

[oe] [PATCH] gpsd: Fix build when static libs disabled

Chris Trobridge  07:58 
To: openembedded-core@lists.openembedded.org

http://lists.openembedded.org/pipermail/openembedded-devel/2016-February/106230.html

> Fix this build error:
> SCons Error: no such option: --disable-static
> Signed-off-by: Maxin B. John <maxin.john at intel.com>
> ---
>  meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb | 1 +
>  1 file changed, 1 insertion(+)
> diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> index ff268b3..a300595 100644
> --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> @@ -47,6 +47,7 @@ EXTRA_OESCONS = " \
>      systemd='${SYSTEMD_OESCONS}' \
>      ${EXTRA_OECONF} \
>  "
> +DISABLE_STATIC = ""
>  & this cannot be used, because then chrpath is not found and only static lib is built
>  & target=${HOST_SYS}
>  
> -- 
> 2.4.0

While this fixes the build, is it just fixing the symptom?

I have a patch that copies the fix in:

http://lists.openembedded.org/pipermail/openembedded-devel/2016-February/106251.html

That is: use EXTRA_CONF_PACKAGECONFIG instead of EXTRA_OECONF, as mentioned the above diff.

This prevents the option being pulled in in the first place, which ought to be a more general solution.

Regards,
Chris

 		 	   		  

Re: [PATCH] gpsd: Fix build when static libs disabled

[Maxin B. John]

Hi Chris,

On Tue, Mar 01, 2016 at 08:12:30AM +0000, Chris Trobridge wrote:
> 
> 
> [oe] [PATCH] gpsd: Fix build when static libs disabled
> 
> Chris Trobridge  07:58 
> To: openembedded-core@lists.openembedded.org
> 
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-February/106230.html
> 
> > Fix this build error:
> > SCons Error: no such option: --disable-static
> > Signed-off-by: Maxin B. John <maxin.john at intel.com>
> > ---
> >  meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb | 1 +
> >  1 file changed, 1 insertion(+)
> > diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > index ff268b3..a300595 100644
> > --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.14.bb
> > @@ -47,6 +47,7 @@ EXTRA_OESCONS = " \
> >      systemd='${SYSTEMD_OESCONS}' \
> >      ${EXTRA_OECONF} \
> >  "
> > +DISABLE_STATIC = ""
> >  & this cannot be used, because then chrpath is not found and only static lib is built
> >  & target=${HOST_SYS}
> >  
> > -- 
> > 2.4.0
> 
> While this fixes the build, is it just fixing the symptom?
> 
> I have a patch that copies the fix in:
> 
> http://lists.openembedded.org/pipermail/openembedded-devel/2016-February/106251.html
> 
> That is: use EXTRA_CONF_PACKAGECONFIG instead of EXTRA_OECONF, as mentioned the above diff.
> 
> This prevents the option being pulled in in the first place, which ought to be a more general solution.
>

Once that EXTRA_CONF_PACKAGECONFIG related patch merged in oe-core, please drop my fix
and go ahead with this patch.

> Regards,
> Chris

Best Regards,
Maxin