[meta-oe][PATCH] openobex: explicitly set ASNEEDED from openobex recipe

[meta-oe][PATCH] openobex: explicitly set ASNEEDED from openobex recipe

[Andre McCurdy]

Up to now, an openobex specific over-ride for ASNEEDED has been
provided by oe-core (from as-needed.inc). If ASNEEDED does need to be
over-ridden in order to build openobex it's not ideal that the
over-ride comes from a different layer so define it directly in the
meta-oe recipe.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb b/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
index 2db48f3..1b56685 100644
--- a/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
+++ b/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
@@ -25,6 +25,8 @@ EXTRA_OECMAKE += "-DBUILD_DOCUMENTATION=OFF"
 
 #--enable-apps --enable-syslog
 
+ASNEEDED = ""
+
 do_install_append () {
     rmdir ${D}${bindir}
 }
-- 
1.9.1

Re: [meta-oe][PATCH] openobex: explicitly set ASNEEDED from openobex recipe

[Andrea Adami]

On Sat, May 5, 2018 at 1:09 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
> Up to now, an openobex specific over-ride for ASNEEDED has been
> provided by oe-core (from as-needed.inc). If ASNEEDED does need to be
> over-ridden in order to build openobex it's not ideal that the
> over-ride comes from a different layer so define it directly in the
> meta-oe recipe.
>
Hi,

don't we have a special include for this purpose?
 /meta/conf/distro/include/as-needed.inc
What want we do? ASNEEDED in the recipe or include the as_needed.inc?

For me, patch is ok, all in the recipe (there are just few cases).

Cheers
Andrea

> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb b/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
> index 2db48f3..1b56685 100644
> --- a/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
> +++ b/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
> @@ -25,6 +25,8 @@ EXTRA_OECMAKE += "-DBUILD_DOCUMENTATION=OFF"
>
>  #--enable-apps --enable-syslog
>
> +ASNEEDED = ""
> +
>  do_install_append () {
>      rmdir ${D}${bindir}
>  }
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][PATCH] openobex: explicitly set ASNEEDED from openobex recipe

[Andre McCurdy]

On Tue, May 8, 2018 at 2:24 PM, Andrea Adami <andrea.adami@gmail.com> wrote:
> On Sat, May 5, 2018 at 1:09 AM, Andre McCurdy <armccurdy@gmail.com> wrote:
>> Up to now, an openobex specific over-ride for ASNEEDED has been
>> provided by oe-core (from as-needed.inc). If ASNEEDED does need to be
>> over-ridden in order to build openobex it's not ideal that the
>> over-ride comes from a different layer so define it directly in the
>> meta-oe recipe.
>>
> Hi,
>
> don't we have a special include for this purpose?
>  /meta/conf/distro/include/as-needed.inc
> What want we do? ASNEEDED in the recipe or include the as_needed.inc?

We want to move the ASNEEDED over-ride from as_needed.inc into the
recipe. For a short time during the transition the over-ride will be
applied from both places.

> For me, patch is ok, all in the recipe (there are just few cases).
>
> Cheers
> Andrea
>
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>>  meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb b/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
>> index 2db48f3..1b56685 100644
>> --- a/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
>> +++ b/meta-oe/recipes-connectivity/obex/openobex_1.7.2.bb
>> @@ -25,6 +25,8 @@ EXTRA_OECMAKE += "-DBUILD_DOCUMENTATION=OFF"
>>
>>  #--enable-apps --enable-syslog
>>
>> +ASNEEDED = ""
>> +
>>  do_install_append () {
>>      rmdir ${D}${bindir}
>>  }
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel