From: "Jia, Fang" <fang.jia@windriver.com>
To: Richard Leitner <richard.leitner@skidata.com>,
<openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCH 1/2] Revert "base-files: Define JAVA_HOME by default"
Date: Mon, 25 Feb 2019 10:05:25 +0800 [thread overview]
Message-ID: <1fe84823-ee0b-e93d-f004-e6cc8905eb12@windriver.com> (raw)
In-Reply-To: <cee583cc-c120-8198-8322-d917f6ae1266@skidata.com>
Hi,
Thank you so much.
Next time will do as your instruction definitely. Thanks again.
Regards,
Fang
On 22/02/2019 16:52, Richard Leitner wrote:
> Hi,
> thanks for the patch. Looks good to me now.
> I'll add it to my tests and will give feedback.
>
> Nonetheless things to improve for your next contribution:
> a) Please add [meta-java] to the subject
> b) Please version the patchset when it updates an existing one
> on the mailinglist
>
> Therefore the correct subject prefix for this patchset would have been:
> [oe][meta-java][PATCH V2 1/2]
>
> No problem for this one as I found it, but please keep an eye on that for the
> next time. Thanks.
>
> regards;Richard.L
next prev parent reply other threads:[~2019-02-25 1:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 3:23 [PATCH 1/2] Revert "base-files: Define JAVA_HOME by default" Fang Jia
2019-02-21 3:23 ` [PATCH 2/2] openjdk: add openjdk-config Fang Jia
2019-07-22 2:53 ` Jia, Fang
2019-02-22 8:52 ` [PATCH 1/2] Revert "base-files: Define JAVA_HOME by default" Richard Leitner
2019-02-25 2:05 ` Jia, Fang [this message]
2019-05-30 8:33 ` Jia, Fang
2019-07-19 8:04 ` Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe84823-ee0b-e93d-f004-e6cc8905eb12@windriver.com \
--to=fang.jia@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox