Re: [PATCH] Fix busybox SUID support

[Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>]

[-- Attachment #1: Type: Text/Plain, Size: 1013 bytes --]

Dnia wtorek, 23 lutego 2010 o 20:02:56 Tom Rini napisał(a):
> I was about to just push this and I noticed that a number of
> distributions (SlugOS, Angstrom, Kaelios, micro) currently set
> FEATURE_SUID=y, but it's not actually install SUID.  And since I recall
> some way-back-when's of "busybox SUID is dangerous / crap!", I thought
> it best to post the patch first and let folks speak up / ask me to drop
> FEATURE_SUID=y when I do this.  So, here's the patch:

Ok, but does not it require /etc/something to list which applets are allowed 
to be suid and which are not? 

Hm. checked sources. with FEATURE_SUID suid will be active only for "crontab, 
dnsd, findfs, ipcrm, ipcs, login, passwd, ping, su, traceroute, vlock" 
commands. /etc/busybox.conf is CONFIG_FEATURE_SUID_CONFIG option.

Acked-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]