From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Fix busybox SUID support
Date: Fri, 26 Feb 2010 19:20:30 +0100 [thread overview]
Message-ID: <hm93de$tnt$1@dough.gmane.org> (raw)
In-Reply-To: <4B87EC32.6030807@mwester.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 26-02-10 16:43, Mike Westerhof wrote:
> Tom Rini wrote:
>> I was about to just push this and I noticed that a number of
>> distributions (SlugOS, Angstrom, Kaelios, micro) currently set
>> FEATURE_SUID=y, but it's not actually install SUID. And since I recall
>> some way-back-when's of "busybox SUID is dangerous / crap!", I thought
>> it best to post the patch first and let folks speak up / ask me to drop
>> FEATURE_SUID=y when I do this. So, here's the patch:
>
> In the case of SlugOS, this was deliberate -- the thinking was that we
> would let the user decide if they wanted to run busybox SUID after
> installation. In retrospect, that actually led to more problems than
> good, so this change gets an ACK from me (albeit late - sorry for the
> delay!)
The same logic was applied to angstrom "let users sort it out", but I
think this patch is a better way to go.
Acked-by: Koen Kooi <koen@openembedded.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFLiBDuMkyGM64RGpERAj1iAJ92l81A14+d1zbGez1GZ1B2wtsxRgCdE5oP
sYCctrQ1jucxDfR0R4PMMf8=
=Bi6n
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-02-26 18:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 19:02 [PATCH] Fix busybox SUID support Tom Rini
2010-02-23 19:51 ` Khem Raj
2010-02-23 20:14 ` Tom Rini
2010-02-23 20:23 ` Chris Larson
2010-02-23 21:37 ` Phil Blundell
2010-02-23 22:52 ` Michael 'Mickey' Lauer
2010-02-23 23:01 ` Tom Rini
2010-02-24 10:19 ` Marcin Juszkiewicz
2010-02-24 16:10 ` Tom Rini
2010-02-26 15:43 ` Mike Westerhof
2010-02-26 18:20 ` Koen Kooi [this message]
2010-02-26 20:21 ` C Michael Sundius
2010-02-26 22:26 ` Bernhard Reutner-Fischer
2010-02-26 22:42 ` Phil Blundell
2010-02-26 23:06 ` Bernhard Reutner-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hm93de$tnt$1@dough.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox