qemu: fails to build without zlib-dev installed on buildhost

qemu: fails to build without zlib-dev installed on buildhost

[Thomas Zimmermann]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Hi,
i tried to build an image on a minimal system today, to check which depencies 
are needed to build the image.
First thing that fails is qemu-native. It Fails during do_configure because of 
missing zlib headers.
So i tried to build zlib-native first, but that has changed nothing. After 
looking at the configure script it seems that the check just uses $QEMU_CFLAGS 
which contains only "-I. -I${SRC_DIR}" so adding -I${STAGIUNG_INCDIR_NATIVE} 
to $QEMU_CFLAGS solves that issue.

Please check the following patch, as i've no exprience with 
BBCLASSEXTEND="native" and i don't want to break qemu.

Regards
Thomas

[-- Attachment #2: 0001-qemu-fix-build-without-zlib-headers-installed-on-bui.patch --]
[-- Type: text/x-patch, Size: 1199 bytes --]

From e19f00968b9d865088ef3a45a85825c5fc17edc5 Mon Sep 17 00:00:00 2001
From: Thomas Zimmermann <ml@vdm-design.de>
Date: Mon, 15 Mar 2010 16:42:14 +0100
Subject: [PATCH] qemu: fix build without zlib headers installed on buildhost

*qemu-native fails to build without zlib-dev package installed on buildhost
*configure script just adds -I. and -I${SRC_DIR} to QEMU_CFLAGS to build checks,
 so it fails to build without headers installed on host
*change DEPENDS from zlib to zlib-native to install zlib headers in staging

Signed-off-by: Thomas Zimmermann <ml@vdm-design.de>
---
 recipes/qemu/qemu_0.12.3.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/recipes/qemu/qemu_0.12.3.bb b/recipes/qemu/qemu_0.12.3.bb
index 035b1a5..bc5c251 100644
--- a/recipes/qemu/qemu_0.12.3.bb
+++ b/recipes/qemu/qemu_0.12.3.bb
@@ -1,5 +1,5 @@
 LICENSE = "GPL"
-DEPENDS = "zlib"
+DEPENDS = "zlib-native"
 
 PR = "r0"
 
@@ -32,5 +32,6 @@ EXTRA_OECONF += "--disable-sdl --disable-strip"
 inherit autotools
 
 do_configure() {
+	export QEMU_CFLAGS="-I${STAGING_INCDIR_NATIVE} ${QEMU_CFLAGS}"
 	${S}/configure --prefix=${prefix} ${EXTRA_OECONF}
 }
-- 
1.7.0

Re: qemu: fails to build without zlib-dev installed on buildhost

[Roman I Khimov]

[-- Attachment #1.1: Type: text/plain, Size: 804 bytes --]

В сообщении от Понедельник 15 марта 2010 18:58:45 автор Thomas Zimmermann 
написал:
> Please check the following patch, as i've no exprience with
> BBCLASSEXTEND="native" and i don't want to break qemu.

Thanks for reporting, first of all.

> -DEPENDS = "zlib"
> +DEPENDS = "zlib-native"

zlib-native is already a dependency for qemu-native thanks to BBCLASSEXTEND 
magic.

>  do_configure() {
> +       export QEMU_CFLAGS="-I${STAGING_INCDIR_NATIVE} ${QEMU_CFLAGS}"
>         ${S}/configure --prefix=${prefix} ${EXTRA_OECONF}
>  }

And this one should only be added for native.

So I think something like attached patch should be a bit better. Please try 
that.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #1.2: 0001-qemu-fix-build-with-zlib-dev-missing-on-host.patch --]
[-- Type: text/x-patch, Size: 1169 bytes --]

From e6f9e79ea507644a413be9f0954fb57c6da15286 Mon Sep 17 00:00:00 2001
From: Roman I Khimov <khimov@altell.ru>
Date: Mon, 15 Mar 2010 23:55:00 +0300
Subject: [PATCH] qemu: fix build with zlib-dev missing on host

OE provides its own zlib-native and qemu-native should use that.

Thanks to Thomas Zimmermann <ml@vdm-design.de> for spotting it.

Signed-off-by: Roman I Khimov <khimov@altell.ru>
---
 recipes/qemu/qemu_0.12.3.bb |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/recipes/qemu/qemu_0.12.3.bb b/recipes/qemu/qemu_0.12.3.bb
index 035b1a5..d1971e9 100644
--- a/recipes/qemu/qemu_0.12.3.bb
+++ b/recipes/qemu/qemu_0.12.3.bb
@@ -1,7 +1,7 @@
 LICENSE = "GPL"
 DEPENDS = "zlib"
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "\
     http://download.savannah.gnu.org/releases/qemu/qemu-${PV}.tar.gz;name=qemu-${PV} \
@@ -31,6 +31,10 @@ EXTRA_OECONF += "--disable-sdl --disable-strip"
 
 inherit autotools
 
+do_configure_prepend_virtclass-native() {
+	export QEMU_CFLAGS="-I${STAGING_INCDIR_NATIVE} ${QEMU_CFLAGS}"
+}
+
 do_configure() {
 	${S}/configure --prefix=${prefix} ${EXTRA_OECONF}
 }
-- 
1.6.4.2


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: qemu: fails to build without zlib-dev installed on buildhost

[Roman I Khimov]

[-- Attachment #1: Type: Text/Plain, Size: 373 bytes --]

В сообщении от Вторник 16 марта 2010 00:04:18 автор Roman I Khimov написал:
> So I think something like attached patch should be a bit better. Please try
> that.

OK, actually I've tested it myself and I think we need it, so I'm pushing this 
one.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: qemu: fails to build without zlib-dev installed on buildhost

[Khem Raj]

2010/3/15 Roman I Khimov <roman@khimov.ru>:
> В сообщении от Понедельник 15 марта 2010 18:58:45 автор Thomas Zimmermann
> написал:
>> Please check the following patch, as i've no exprience with
>> BBCLASSEXTEND="native" and i don't want to break qemu.
>
> Thanks for reporting, first of all.
>
>> -DEPENDS = "zlib"
>> +DEPENDS = "zlib-native"
>
> zlib-native is already a dependency for qemu-native thanks to BBCLASSEXTEND
> magic.
>
>>  do_configure() {
>> +       export QEMU_CFLAGS="-I${STAGING_INCDIR_NATIVE} ${QEMU_CFLAGS}"
>>         ${S}/configure --prefix=${prefix} ${EXTRA_OECONF}
>>  }
>
> And this one should only be added for native.

IMO this part seems appropriate for BBCLASSEXTEND also. Its common enough

>
> So I think something like attached patch should be a bit better. Please try
> that.
>
> --
>  http://roman.khimov.ru
> mailto: roman@khimov.ru
> gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>