[PATCH] navit: enable qml build

[PATCH] navit: enable qml build

[Martin Jansa]

* but for now without DEPENDS on qt4-x11-free, because 4.7.0 is not yet
  released and building qt4-x11-free just because of navit (for someone
  not using it for something else) takes a lot of time
* should I add qt as DISTRO_FEATURE like "tk" is used in python DEPENDS?
* I'll add PR bump before pushing, if it's OK to enable it without
  forced qt4 depends (navit build before qt-4.7 wont have qml and
  rebuilded navit after building qt-4.7 will get qml support)
* At least it doesn't fail without qt, even when it's enabled in
 configure param

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes/navit/navit_svn.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/recipes/navit/navit_svn.bb b/recipes/navit/navit_svn.bb
index 2b75c4e..61d5e24 100644
--- a/recipes/navit/navit_svn.bb
+++ b/recipes/navit/navit_svn.bb
@@ -15,7 +15,7 @@ RDEPENDS_${PN} = " navit-icons ${PN}-config "
 DEPENDS_append_shr = " gypsy"
 RDEPENDS_append_shr = " fsoraw"
 
-EXTRA_OECONF += " --enable-svg2png-scaling-flag=32 --disable-speech-speech-dispatcher --enable-cache-size=20971520"
+EXTRA_OECONF += " --enable-svg2png-scaling-flag=32 --disable-speech-speech-dispatcher --enable-cache-size=20971520 --enable-gui-qml"
 
 SRC_URI = "svn://anonymous@navit.svn.sourceforge.net/svnroot/navit/trunk;module=navit;proto=https"
 
-- 
1.7.1

Re: [PATCH] navit: enable qml build

[Holger Freyther]

On 06/11/2010 04:07 AM, Martin Jansa wrote:
> * but for now without DEPENDS on qt4-x11-free, because 4.7.0 is not yet
>   released and building qt4-x11-free just because of navit (for someone
>   not using it for something else) takes a lot of time

I might not understand everything here, but this looks dangerous. A
package rebuild should always generate the same kind of package.

Re: [PATCH] navit: enable qml build

[Martin Jansa]

On Fri, Jun 11, 2010 at 01:53:36PM +0800, Holger Freyther wrote:
> On 06/11/2010 04:07 AM, Martin Jansa wrote:
> > * but for now without DEPENDS on qt4-x11-free, because 4.7.0 is not yet
> >   released and building qt4-x11-free just because of navit (for someone
> >   not using it for something else) takes a lot of time
> 
> I might not understand everything here, but this looks dangerous. A
> package rebuild should always generate the same kind of package.

Yes it's dangerous indeed.

Python DEPENDS contains 
${@base_contains('DISTRO_FEATURES', 'tk', 'tk', '', d)}

Then it's ensured that if you have tk in DISTRO_FEATURES then it's
picked by automatic in do_configure. But if you don't have it in
DISTRO_FEATURES then it depends if you build something depending on tk
before trying to build python or not. Even worse case is when you build
an image (ie kernel, python (without tk), th, something_depending_on_tk)
and then someone PR bump python and now you'll get python with tk).

I guess there is plenty of examples where configure has "automatic" by
default and we don't DEPEND on optional stuff and also don't force it
with --disable-some-optional-feature :/.

I think that best solution would be something like
DEPENDS += "${@base_contains('DISTRO_FEATURES', 'qt', 'qt4-x11-free', '', d)}"
EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'qt', '--enable-gui-qml', '--disable-gui-qml', d)}"

which is not so common in OE AFAIK and looks like how USE flags are
handled in gentoo (but they have better syntax to make it shorter).

Regards,

-- 
Jansa 'JaMa' Martin     jabber: Martin.Jansa@gmail.com