Re: [PATCH] omap3/powervr-drivers: Cleanups & fixes

[Andreas Mueller <schnitzeltony@gmx.de>]

On Tuesday 20 July 2010 07:04:08 pm Koen Kooi wrote:
> > 1. Merge omap3-sgx-modules -> libgles-omap3:
> >       Reduce memory & built time consumption.
> >       Note: By 'inherit module' all libgles packages
> >       get machine specific.
> 
> NAK on that, the split is done this way on purpose. Making the libs
> machine specific is NOT acceptable.
We got a similar discussion on clutter-box2d (but in the other way round). On my question for a rule when to make packages machine specific or not I got no response - I don't expect it now.
> > 2. Work around the missing (??) function omap_rev_lt_3_0()
> 
> It's not missing, it's present in all omap3 kernels in .dev that are
> supported. This incarnation of the test wasn't accepted upstream, but
> it's easy enough to patch in.
All the guys sitting on the gumstix tree like me are missing it. The latest driver is simply diabled with a commit msg. like 'does not build for kernel > 2.6.32'
> > 3. Make kernel modules buildable for kernel 2.6.33
> >       (fix-1.4.14.2616-for-kernel-gt-2.6.32.patch)
> > 4. Install script 'cpu-sgx-rev' returning the SGX version
> >       supported by CPU (2.x / 3.x / 5.x)
> 
> And NAK on that as well, the existing script handles that already. I
> know that since I have all those ES revisions on my desk :)
Do you mean the init script - or am I missing something?
> So basically only 3) and maybe 2) would be acceptable.
NAK My main intention was to reduce massive time and memory consumption - end of the story for me

regards

Andreas