Re: [PATCH] omap3/powervr-drivers: Cleanups & fixes

[Koen Kooi <k.kooi@student.utwente.nl>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 20-07-10 16:54, Andreas Mueller wrote:
> From ee328e5f8b905ec8a2c3de1664679ff1c442e7fa Mon Sep 17 00:00:00 2001
> From: Andreas Mueller <schnitzeltony@gmx.de>
> Date: Tue, 20 Jul 2010 16:15:37 +0200
> Subject: [PATCH] omap3/powervr-drivers: Cleanups & fixes
> 
> 1. Merge omap3-sgx-modules -> libgles-omap3:
>       Reduce memory & built time consumption.
>       Note: By 'inherit module' all libgles packages
>       get machine specific.

NAK on that, the split is done this way on purpose. Making the libs
machine specific is NOT acceptable.

> 2. Work around the missing (??) function omap_rev_lt_3_0()

It's not missing, it's present in all omap3 kernels in .dev that are
supported. This incarnation of the test wasn't accepted upstream, but
it's easy enough to patch in.

>       Reading the comment leads to the following
>       interpretation: return true for SGXVersion less than
>       3.x.

It's not SGX rev, since that would be something like 121 or 125, but ES
revision of the omap3.


> 3. Make kernel modules buildable for kernel 2.6.33
>       (fix-1.4.14.2616-for-kernel-gt-2.6.32.patch)
> 4. Install script 'cpu-sgx-rev' returning the SGX version
>       supported by CPU (2.x / 3.x / 5.x)

And NAK on that as well, the existing script handles that already. I
know that since I have all those ES revisions on my desk :)

So basically only 3) and maybe 2) would be acceptable.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMRdcIMkyGM64RGpERAndHAKCW5HVAukQqRT1aH51J9UqHXFvbwgCfSiOm
s3L0AyWIfpmPjZcWuM5opTk=
=7yr9
-----END PGP SIGNATURE-----