From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 10/12] busybox: simplify update-rc.d OPT handling
Date: Mon, 3 Jan 2011 22:09:26 +0100 [thread overview]
Message-ID: <20110103210926.GE25803@mx.loc> (raw)
In-Reply-To: <201101032330.21527.roman@khimov.ru>
On Mon, Jan 03, 2011 at 11:30:21PM +0300, Roman I Khimov wrote:
>В сообщении от Понедельник 03 января 2011 23:02:04 автор Bernhard Reutner-
>Fischer написал:
>> - if test "x$D" != "x"; then
>> - OPT="-r $D"
>> - else
>> - OPT="-s"
>> - fi
>> + [ -n "$D" ] && OPT="-r $D" || OPT="-s"
>
>I have a strong feeling that this is wrong. Yeah, the first one takes up five
>times more lines but to me it's about five times easier to parse glancing over
>the recipe.
>
>Also, from what I heard '"x$D" != "x"' tests are the most portable ones.
It is more portable, yes. But given that test(1) is required to support
both -n and -z even in SUSv3 -- and still is in SUSv4 and i doubt this
fact will change anytime soon -- it's sane to assume it works.
ok?
next prev parent reply other threads:[~2011-01-03 21:09 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 20:01 [PATCH 01/12] gstd: fix type in RRECOMENDS Bernhard Reutner-Fischer
2011-01-03 20:01 ` [PATCH 02/12] class_image: fix typos Bernhard Reutner-Fischer
2011-01-03 20:28 ` Roman I Khimov
2011-01-03 20:01 ` [PATCH 03/12] image.bbclass: rm symlink destination via ln Bernhard Reutner-Fischer
2011-01-03 20:31 ` Roman I Khimov
2011-01-03 20:01 ` [PATCH 04/12] bitbake.conf: add cpio and ext4 .xz support Bernhard Reutner-Fischer
2011-01-03 20:01 ` [PATCH 05/12] uclibc: shared-flat: put crtreloc.o into -dev package Bernhard Reutner-Fischer
2011-01-11 19:47 ` Bernhard Reutner-Fischer
2011-01-12 7:43 ` Khem Raj
2011-01-03 20:02 ` [PATCH 06/12] busybox: remove superfluous newlines from mdev init script Bernhard Reutner-Fischer
2011-01-03 20:37 ` Roman I Khimov
2011-01-03 20:02 ` [PATCH 07/12] busybox: simplify handling of busybox-static Bernhard Reutner-Fischer
2011-01-11 19:53 ` Bernhard Reutner-Fischer
2011-01-12 20:41 ` Otavio Salvador
2011-01-03 20:02 ` [PATCH 08/12] busybox: provide -passwd and -shadow packages Bernhard Reutner-Fischer
2011-01-03 21:01 ` Roman I Khimov
2011-01-03 21:13 ` Bernhard Reutner-Fischer
2011-01-03 20:02 ` [PATCH 09/12] busybox: provide postrm for package mdev Bernhard Reutner-Fischer
2011-01-03 20:54 ` Roman I Khimov
2011-01-04 11:58 ` Wolfgang Hauser
2011-01-04 12:22 ` Otavio Salvador
2011-01-04 12:54 ` Wolfgang Hauser
2011-01-11 19:41 ` Bernhard Reutner-Fischer
2011-01-12 11:07 ` Otavio Salvador
2011-01-03 20:02 ` [PATCH 10/12] busybox: simplify update-rc.d OPT handling Bernhard Reutner-Fischer
2011-01-03 20:30 ` Roman I Khimov
2011-01-03 21:09 ` Bernhard Reutner-Fischer [this message]
2011-01-13 22:17 ` Otavio Salvador
2011-01-03 20:02 ` [PATCH 11/12] glib-2.0: fix compilation for !IPv6 Bernhard Reutner-Fischer
2011-01-03 20:02 ` [PATCH 12/12] xz: bump version Bernhard Reutner-Fischer
2011-01-11 20:18 ` Bernhard Reutner-Fischer
2011-01-12 7:40 ` Khem Raj
2011-01-03 20:12 ` [PATCH 01/12] gstd: fix type in RRECOMENDS Frans Meulenbroeks
2011-01-03 20:16 ` Koen Kooi
2011-01-03 20:31 ` Bernhard Reutner-Fischer
2011-01-03 20:28 ` Roman I Khimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103210926.GE25803@mx.loc \
--to=rep.dot.nop@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox