Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 09/12] busybox: provide postrm for package mdev
Date: Tue, 11 Jan 2011 20:41:10 +0100	[thread overview]
Message-ID: <20110111194110.GC6584@mx.loc> (raw)
In-Reply-To: <4D23186C.8080803@gmx.de>

On Tue, Jan 04, 2011 at 01:54:04PM +0100, Wolfgang Hauser wrote:
>I agree for the test statement, but that may be solved by using ´the
>brackets in the long statement.
>
>Otavio Salvador schrieb:
>> On Tue, Jan 4, 2011 at 09:58, Wolfgang Hauser <wohauser@gmx.de> wrote:
>>> Keep it simple and stupid!
>>> So I vote for the long, readable and less error prone version.
>> 
>> I usually prefer the KISS however on this specific case I disagree.
>> 
>> The new code avoid using test and a fork. This allows for "test"
>> applet removal if desired.
>> 
>> I prefer the ugly but more "embedded like" code.

remember that this stuff potentially ends up on the target, so KISS
(byte-wise) is always the preferred way. And yes, update-rc.d and the
required inode itself is bloat, but heck, if you want online
pkg-management you have to take that penalty, FWIW.

So.. Can i please have an explicit ACK for that space-saver?



  reply	other threads:[~2011-01-11 19:41 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-03 20:01 [PATCH 01/12] gstd: fix type in RRECOMENDS Bernhard Reutner-Fischer
2011-01-03 20:01 ` [PATCH 02/12] class_image: fix typos Bernhard Reutner-Fischer
2011-01-03 20:28   ` Roman I Khimov
2011-01-03 20:01 ` [PATCH 03/12] image.bbclass: rm symlink destination via ln Bernhard Reutner-Fischer
2011-01-03 20:31   ` Roman I Khimov
2011-01-03 20:01 ` [PATCH 04/12] bitbake.conf: add cpio and ext4 .xz support Bernhard Reutner-Fischer
2011-01-03 20:01 ` [PATCH 05/12] uclibc: shared-flat: put crtreloc.o into -dev package Bernhard Reutner-Fischer
2011-01-11 19:47   ` Bernhard Reutner-Fischer
2011-01-12  7:43     ` Khem Raj
2011-01-03 20:02 ` [PATCH 06/12] busybox: remove superfluous newlines from mdev init script Bernhard Reutner-Fischer
2011-01-03 20:37   ` Roman I Khimov
2011-01-03 20:02 ` [PATCH 07/12] busybox: simplify handling of busybox-static Bernhard Reutner-Fischer
2011-01-11 19:53   ` Bernhard Reutner-Fischer
2011-01-12 20:41     ` Otavio Salvador
2011-01-03 20:02 ` [PATCH 08/12] busybox: provide -passwd and -shadow packages Bernhard Reutner-Fischer
2011-01-03 21:01   ` Roman I Khimov
2011-01-03 21:13     ` Bernhard Reutner-Fischer
2011-01-03 20:02 ` [PATCH 09/12] busybox: provide postrm for package mdev Bernhard Reutner-Fischer
2011-01-03 20:54   ` Roman I Khimov
2011-01-04 11:58     ` Wolfgang Hauser
2011-01-04 12:22       ` Otavio Salvador
2011-01-04 12:54         ` Wolfgang Hauser
2011-01-11 19:41           ` Bernhard Reutner-Fischer [this message]
2011-01-12 11:07             ` Otavio Salvador
2011-01-03 20:02 ` [PATCH 10/12] busybox: simplify update-rc.d OPT handling Bernhard Reutner-Fischer
2011-01-03 20:30   ` Roman I Khimov
2011-01-03 21:09     ` Bernhard Reutner-Fischer
2011-01-13 22:17   ` Otavio Salvador
2011-01-03 20:02 ` [PATCH 11/12] glib-2.0: fix compilation for !IPv6 Bernhard Reutner-Fischer
2011-01-03 20:02 ` [PATCH 12/12] xz: bump version Bernhard Reutner-Fischer
2011-01-11 20:18   ` Bernhard Reutner-Fischer
2011-01-12  7:40     ` Khem Raj
2011-01-03 20:12 ` [PATCH 01/12] gstd: fix type in RRECOMENDS Frans Meulenbroeks
2011-01-03 20:16 ` Koen Kooi
2011-01-03 20:31   ` Bernhard Reutner-Fischer
2011-01-03 20:28 ` Roman I Khimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110111194110.GC6584@mx.loc \
    --to=rep.dot.nop@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox