* [meta-oe][PATCH] rng-tools: Fixes for latest OE layouts @ 2012-12-14 21:05 Gary Thomas 2012-12-16 18:00 ` Martin Jansa 0 siblings, 1 reply; 6+ messages in thread From: Gary Thomas @ 2012-12-14 21:05 UTC (permalink / raw) To: openembedded-devel The current recipe has a few installation errors: * The manipulation of configurable paths drops a '/' * The init script defaults are placed in the wrong file * Finer control over init script start/stop * The default device is non-standard This patch fixes these little nits and makes the package usable again. Signed-off-by: Gary Thomas <gary@mlbassoc.com> --- meta-oe/recipes-support/rng-tools/files/default | 3 ++- meta-oe/recipes-support/rng-tools/rng-tools_2.bb | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/meta-oe/recipes-support/rng-tools/files/default b/meta-oe/recipes-support/rng-tools/files/default index ab7cd93..7aede9b 100644 --- a/meta-oe/recipes-support/rng-tools/files/default +++ b/meta-oe/recipes-support/rng-tools/files/default @@ -1,2 +1,3 @@ # Specify rng device -RNG_DEVICE=/dev/hwrng +#RNG_DEVICE=/dev/hwrng +RNG_DEVICE=/dev/urandom diff --git a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb index ef753cf..b94854a 100644 --- a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb +++ b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb @@ -15,12 +15,13 @@ inherit autotools update-rc.d do_install_append() { install -d "${D}${sysconfdir}/init.d" install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/rng-tools - sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir},' \ + sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir}/,' \ ${D}${sysconfdir}/init.d/rng-tools install -d "${D}${sysconfdir}/default" - install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/default + install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/rng-tools } INITSCRIPT_NAME = "rng-tools" INITSCRIPT_PARAMS = "defaults" +INITSCRIPT_PARAMS = "start 30 S . stop 30 0 6 1 ." -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] rng-tools: Fixes for latest OE layouts 2012-12-14 21:05 [meta-oe][PATCH] rng-tools: Fixes for latest OE layouts Gary Thomas @ 2012-12-16 18:00 ` Martin Jansa 2013-01-09 14:21 ` Martin Jansa 0 siblings, 1 reply; 6+ messages in thread From: Martin Jansa @ 2012-12-16 18:00 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2177 bytes --] On Fri, Dec 14, 2012 at 02:05:48PM -0700, Gary Thomas wrote: > The current recipe has a few installation errors: > * The manipulation of configurable paths drops a '/' > * The init script defaults are placed in the wrong file > * Finer control over init script start/stop > * The default device is non-standard > > This patch fixes these little nits and makes the package usable again. > > Signed-off-by: Gary Thomas <gary@mlbassoc.com> > --- > meta-oe/recipes-support/rng-tools/files/default | 3 ++- > meta-oe/recipes-support/rng-tools/rng-tools_2.bb | 5 +++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/meta-oe/recipes-support/rng-tools/files/default b/meta-oe/recipes-support/rng-tools/files/default > index ab7cd93..7aede9b 100644 > --- a/meta-oe/recipes-support/rng-tools/files/default > +++ b/meta-oe/recipes-support/rng-tools/files/default > @@ -1,2 +1,3 @@ > # Specify rng device > -RNG_DEVICE=/dev/hwrng > +#RNG_DEVICE=/dev/hwrng > +RNG_DEVICE=/dev/urandom > diff --git a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > index ef753cf..b94854a 100644 > --- a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > +++ b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > @@ -15,12 +15,13 @@ inherit autotools update-rc.d > do_install_append() { > install -d "${D}${sysconfdir}/init.d" > install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/rng-tools > - sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir},' \ > + sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir}/,' \ > ${D}${sysconfdir}/init.d/rng-tools > > install -d "${D}${sysconfdir}/default" > - install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/default > + install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/rng-tools > } > > INITSCRIPT_NAME = "rng-tools" > INITSCRIPT_PARAMS = "defaults" > +INITSCRIPT_PARAMS = "start 30 S . stop 30 0 6 1 ." Why do you add 2nd INITSCRIPT_PARAMS ? Cheers, -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] rng-tools: Fixes for latest OE layouts 2012-12-16 18:00 ` Martin Jansa @ 2013-01-09 14:21 ` Martin Jansa 2013-01-09 14:34 ` Gary Thomas 0 siblings, 1 reply; 6+ messages in thread From: Martin Jansa @ 2013-01-09 14:21 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2332 bytes --] On Sun, Dec 16, 2012 at 07:00:22PM +0100, Martin Jansa wrote: > On Fri, Dec 14, 2012 at 02:05:48PM -0700, Gary Thomas wrote: > > The current recipe has a few installation errors: > > * The manipulation of configurable paths drops a '/' > > * The init script defaults are placed in the wrong file > > * Finer control over init script start/stop > > * The default device is non-standard > > > > This patch fixes these little nits and makes the package usable again. > > > > Signed-off-by: Gary Thomas <gary@mlbassoc.com> > > --- > > meta-oe/recipes-support/rng-tools/files/default | 3 ++- > > meta-oe/recipes-support/rng-tools/rng-tools_2.bb | 5 +++-- > > 2 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/meta-oe/recipes-support/rng-tools/files/default b/meta-oe/recipes-support/rng-tools/files/default > > index ab7cd93..7aede9b 100644 > > --- a/meta-oe/recipes-support/rng-tools/files/default > > +++ b/meta-oe/recipes-support/rng-tools/files/default > > @@ -1,2 +1,3 @@ > > # Specify rng device > > -RNG_DEVICE=/dev/hwrng > > +#RNG_DEVICE=/dev/hwrng > > +RNG_DEVICE=/dev/urandom > > diff --git a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > > index ef753cf..b94854a 100644 > > --- a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > > +++ b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > > @@ -15,12 +15,13 @@ inherit autotools update-rc.d > > do_install_append() { > > install -d "${D}${sysconfdir}/init.d" > > install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/rng-tools > > - sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir},' \ > > + sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir}/,' \ > > ${D}${sysconfdir}/init.d/rng-tools > > > > install -d "${D}${sysconfdir}/default" > > - install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/default > > + install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/rng-tools > > } > > > > INITSCRIPT_NAME = "rng-tools" > > INITSCRIPT_PARAMS = "defaults" > > +INITSCRIPT_PARAMS = "start 30 S . stop 30 0 6 1 ." > > Why do you add 2nd INITSCRIPT_PARAMS ? ping :) -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] rng-tools: Fixes for latest OE layouts 2013-01-09 14:21 ` Martin Jansa @ 2013-01-09 14:34 ` Gary Thomas 2013-01-10 11:27 ` Martin Jansa 0 siblings, 1 reply; 6+ messages in thread From: Gary Thomas @ 2013-01-09 14:34 UTC (permalink / raw) To: openembedded-devel On 2013-01-09 07:21, Martin Jansa wrote: > On Sun, Dec 16, 2012 at 07:00:22PM +0100, Martin Jansa wrote: >> On Fri, Dec 14, 2012 at 02:05:48PM -0700, Gary Thomas wrote: >>> The current recipe has a few installation errors: >>> * The manipulation of configurable paths drops a '/' >>> * The init script defaults are placed in the wrong file >>> * Finer control over init script start/stop >>> * The default device is non-standard >>> >>> This patch fixes these little nits and makes the package usable again. >>> >>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> >>> --- >>> meta-oe/recipes-support/rng-tools/files/default | 3 ++- >>> meta-oe/recipes-support/rng-tools/rng-tools_2.bb | 5 +++-- >>> 2 files changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --git a/meta-oe/recipes-support/rng-tools/files/default b/meta-oe/recipes-support/rng-tools/files/default >>> index ab7cd93..7aede9b 100644 >>> --- a/meta-oe/recipes-support/rng-tools/files/default >>> +++ b/meta-oe/recipes-support/rng-tools/files/default >>> @@ -1,2 +1,3 @@ >>> # Specify rng device >>> -RNG_DEVICE=/dev/hwrng >>> +#RNG_DEVICE=/dev/hwrng >>> +RNG_DEVICE=/dev/urandom >>> diff --git a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb >>> index ef753cf..b94854a 100644 >>> --- a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb >>> +++ b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb >>> @@ -15,12 +15,13 @@ inherit autotools update-rc.d >>> do_install_append() { >>> install -d "${D}${sysconfdir}/init.d" >>> install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/rng-tools >>> - sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir},' \ >>> + sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir}/,' \ >>> ${D}${sysconfdir}/init.d/rng-tools >>> >>> install -d "${D}${sysconfdir}/default" >>> - install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/default >>> + install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/rng-tools >>> } >>> >>> INITSCRIPT_NAME = "rng-tools" >>> INITSCRIPT_PARAMS = "defaults" >>> +INITSCRIPT_PARAMS = "start 30 S . stop 30 0 6 1 ." >> >> Why do you add 2nd INITSCRIPT_PARAMS ? > > ping :) Sorry, must have missed your query (holidays). That second line should really replace the first for finer grain control over the start/stop choice. I can fix this and resend the patch. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] rng-tools: Fixes for latest OE layouts 2013-01-09 14:34 ` Gary Thomas @ 2013-01-10 11:27 ` Martin Jansa 2013-02-25 19:26 ` Martin Jansa 0 siblings, 1 reply; 6+ messages in thread From: Martin Jansa @ 2013-01-10 11:27 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2806 bytes --] On Wed, Jan 09, 2013 at 07:34:05AM -0700, Gary Thomas wrote: > On 2013-01-09 07:21, Martin Jansa wrote: > > On Sun, Dec 16, 2012 at 07:00:22PM +0100, Martin Jansa wrote: > >> On Fri, Dec 14, 2012 at 02:05:48PM -0700, Gary Thomas wrote: > >>> The current recipe has a few installation errors: > >>> * The manipulation of configurable paths drops a '/' > >>> * The init script defaults are placed in the wrong file > >>> * Finer control over init script start/stop > >>> * The default device is non-standard > >>> > >>> This patch fixes these little nits and makes the package usable again. > >>> > >>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> > >>> --- > >>> meta-oe/recipes-support/rng-tools/files/default | 3 ++- > >>> meta-oe/recipes-support/rng-tools/rng-tools_2.bb | 5 +++-- > >>> 2 files changed, 5 insertions(+), 3 deletions(-) > >>> > >>> diff --git a/meta-oe/recipes-support/rng-tools/files/default b/meta-oe/recipes-support/rng-tools/files/default > >>> index ab7cd93..7aede9b 100644 > >>> --- a/meta-oe/recipes-support/rng-tools/files/default > >>> +++ b/meta-oe/recipes-support/rng-tools/files/default > >>> @@ -1,2 +1,3 @@ > >>> # Specify rng device > >>> -RNG_DEVICE=/dev/hwrng > >>> +#RNG_DEVICE=/dev/hwrng > >>> +RNG_DEVICE=/dev/urandom > >>> diff --git a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > >>> index ef753cf..b94854a 100644 > >>> --- a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > >>> +++ b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > >>> @@ -15,12 +15,13 @@ inherit autotools update-rc.d > >>> do_install_append() { > >>> install -d "${D}${sysconfdir}/init.d" > >>> install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/rng-tools > >>> - sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir},' \ > >>> + sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir}/,' \ > >>> ${D}${sysconfdir}/init.d/rng-tools > >>> > >>> install -d "${D}${sysconfdir}/default" > >>> - install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/default > >>> + install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/rng-tools > >>> } > >>> > >>> INITSCRIPT_NAME = "rng-tools" > >>> INITSCRIPT_PARAMS = "defaults" > >>> +INITSCRIPT_PARAMS = "start 30 S . stop 30 0 6 1 ." > >> > >> Why do you add 2nd INITSCRIPT_PARAMS ? > > > > ping :) > > Sorry, must have missed your query (holidays). > > That second line should really replace the first for finer grain > control over the start/stop choice. I can fix this and resend the patch. Yes, please do if you want it applied. Cheers, -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH] rng-tools: Fixes for latest OE layouts 2013-01-10 11:27 ` Martin Jansa @ 2013-02-25 19:26 ` Martin Jansa 0 siblings, 0 replies; 6+ messages in thread From: Martin Jansa @ 2013-02-25 19:26 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 3193 bytes --] On Thu, Jan 10, 2013 at 12:27:54PM +0100, Martin Jansa wrote: > On Wed, Jan 09, 2013 at 07:34:05AM -0700, Gary Thomas wrote: > > On 2013-01-09 07:21, Martin Jansa wrote: > > > On Sun, Dec 16, 2012 at 07:00:22PM +0100, Martin Jansa wrote: > > >> On Fri, Dec 14, 2012 at 02:05:48PM -0700, Gary Thomas wrote: > > >>> The current recipe has a few installation errors: > > >>> * The manipulation of configurable paths drops a '/' > > >>> * The init script defaults are placed in the wrong file > > >>> * Finer control over init script start/stop > > >>> * The default device is non-standard > > >>> > > >>> This patch fixes these little nits and makes the package usable again. > > >>> > > >>> Signed-off-by: Gary Thomas <gary@mlbassoc.com> > > >>> --- > > >>> meta-oe/recipes-support/rng-tools/files/default | 3 ++- > > >>> meta-oe/recipes-support/rng-tools/rng-tools_2.bb | 5 +++-- > > >>> 2 files changed, 5 insertions(+), 3 deletions(-) > > >>> > > >>> diff --git a/meta-oe/recipes-support/rng-tools/files/default b/meta-oe/recipes-support/rng-tools/files/default > > >>> index ab7cd93..7aede9b 100644 > > >>> --- a/meta-oe/recipes-support/rng-tools/files/default > > >>> +++ b/meta-oe/recipes-support/rng-tools/files/default > > >>> @@ -1,2 +1,3 @@ > > >>> # Specify rng device > > >>> -RNG_DEVICE=/dev/hwrng > > >>> +#RNG_DEVICE=/dev/hwrng > > >>> +RNG_DEVICE=/dev/urandom > > >>> diff --git a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > > >>> index ef753cf..b94854a 100644 > > >>> --- a/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > > >>> +++ b/meta-oe/recipes-support/rng-tools/rng-tools_2.bb > > >>> @@ -15,12 +15,13 @@ inherit autotools update-rc.d > > >>> do_install_append() { > > >>> install -d "${D}${sysconfdir}/init.d" > > >>> install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/rng-tools > > >>> - sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir},' \ > > >>> + sed -i -e 's,/etc/,${sysconfdir}/,' -e 's,/usr/sbin/,${sbindir}/,' \ > > >>> ${D}${sysconfdir}/init.d/rng-tools > > >>> > > >>> install -d "${D}${sysconfdir}/default" > > >>> - install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/default > > >>> + install -m 0644 ${WORKDIR}/default ${D}${sysconfdir}/rng-tools > > >>> } > > >>> > > >>> INITSCRIPT_NAME = "rng-tools" > > >>> INITSCRIPT_PARAMS = "defaults" > > >>> +INITSCRIPT_PARAMS = "start 30 S . stop 30 0 6 1 ." > > >> > > >> Why do you add 2nd INITSCRIPT_PARAMS ? > > > > > > ping :) > > > > Sorry, must have missed your query (holidays). > > > > That second line should really replace the first for finer grain > > control over the start/stop choice. I can fix this and resend the patch. > > Yes, please do if you want it applied. Last call for update. Next week I'll remove it from my queue and mark it as "Changes requested" on patchwork when not updated. > > Cheers, > -- > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-25 19:42 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-12-14 21:05 [meta-oe][PATCH] rng-tools: Fixes for latest OE layouts Gary Thomas 2012-12-16 18:00 ` Martin Jansa 2013-01-09 14:21 ` Martin Jansa 2013-01-09 14:34 ` Gary Thomas 2013-01-10 11:27 ` Martin Jansa 2013-02-25 19:26 ` Martin Jansa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox