* [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8
@ 2013-06-01 18:03 Martin Jansa
2013-06-02 8:09 ` Martin Jansa
0 siblings, 1 reply; 7+ messages in thread
From: Martin Jansa @ 2013-06-01 18:03 UTC (permalink / raw)
To: openembedded-devel
---
...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
meta-efl/recipes-efl/webkit/webkit-efl_svn.bb | 3 +-
2 files changed, 45 insertions(+), 1 deletion(-)
create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
diff --git a/meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch b/meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
new file mode 100644
index 0000000..f553663
--- /dev/null
+++ b/meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
@@ -0,0 +1,43 @@
+From 3de7c4633751c3e55152d4e2429dfcc0f69a1de3 Mon Sep 17 00:00:00 2001
+From: Martin Jansa <Martin.Jansa@gmail.com>
+Date: Sat, 1 Jun 2013 19:23:54 +0200
+Subject: [PATCH] ewk: include Element.h for hasTagName function
+
+* ewebkit build fails like gtk in http://trac.webkit.org/changeset/72745
+ | ../../../lib/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::Node::hasTagName(WebCore::QualifiedName const&) const'
+ | collect2: error: ld returned 1 exit status
+ | make[2]: *** [bin/DumpRenderTree] Error 1
+
+Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
+---
+ Source/WebKit/efl/ewk/ewk_frame.cpp | 1 +
+ Source/WebKit/efl/ewk/ewk_view.cpp | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/Source/WebKit/efl/ewk/ewk_frame.cpp b/Source/WebKit/efl/ewk/ewk_frame.cpp
+index fd1ffd2..c86601a 100644
+--- a/Source/WebKit/efl/ewk/ewk_frame.cpp
++++ b/Source/WebKit/efl/ewk/ewk_frame.cpp
+@@ -32,6 +32,7 @@
+ #include "FocusController.h"
+ #include "FrameLoaderClientEfl.h"
+ #include "FrameView.h"
++#include "Element.h"
+ #include "HTMLCollection.h"
+ #include "HTMLHeadElement.h"
+ #include "HTMLImageElement.h"
+diff --git a/Source/WebKit/efl/ewk/ewk_view.cpp b/Source/WebKit/efl/ewk/ewk_view.cpp
+index 9798e94..7a5da60 100644
+--- a/Source/WebKit/efl/ewk/ewk_view.cpp
++++ b/Source/WebKit/efl/ewk/ewk_view.cpp
+@@ -36,6 +36,7 @@
+ #include "FocusController.h"
+ #include "FrameLoaderClientEfl.h"
+ #include "FrameView.h"
++#include "Element.h"
+ #include "GraphicsContext.h"
+ #include "HTMLElement.h"
+ #include "HTMLInputElement.h"
+--
+1.8.2.1
+
diff --git a/meta-efl/recipes-efl/webkit/webkit-efl_svn.bb b/meta-efl/recipes-efl/webkit/webkit-efl_svn.bb
index be5a534..ce73431 100644
--- a/meta-efl/recipes-efl/webkit/webkit-efl_svn.bb
+++ b/meta-efl/recipes-efl/webkit/webkit-efl_svn.bb
@@ -12,7 +12,7 @@ DEPENDS = "icu libxslt sqlite3 gperf-native bison-native flex-native jpeg \
# 120145 and 122103 introduces dependency on libsoup-2.39.3 and glib-networking-2.33.2
SRCREV = "120144"
PV = "1.9.3+svnr${SRCPV}"
-PR = "r2"
+PR = "r3"
SRCREV_FORMAT = "source"
@@ -22,6 +22,7 @@ SRC_URI = "\
svn://svn.webkit.org/repository/webkit/trunk;module=Source;name=source;protocol=http;subdir=src \
svn://svn.webkit.org/repository/webkit/trunk/;module=WebKitLibraries;protocol=http;subdir=src \
svn://svn.webkit.org/repository/webkit/trunk/;module=Tools;protocol=http;subdir=src \
+ file://0001-ewk-include-Element.h-for-hasTagName-function.patch \
file://CMakeLists.txt \
file://bison-2.6.patch \
"
--
1.8.2.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8
2013-06-01 18:03 [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8 Martin Jansa
@ 2013-06-02 8:09 ` Martin Jansa
2013-06-06 12:34 ` Martin Jansa
0 siblings, 1 reply; 7+ messages in thread
From: Martin Jansa @ 2013-06-02 8:09 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
On Sat, Jun 01, 2013 at 08:03:22PM +0200, Martin Jansa wrote:
> ---
> ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
> meta-efl/recipes-efl/webkit/webkit-efl_svn.bb | 3 +-
> 2 files changed, 45 insertions(+), 1 deletion(-)
> create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
Ignore this one, it works on armv7a, but fails the same on armv4t and
x86_64 + there is ICE when building for armv5te.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8
2013-06-02 8:09 ` Martin Jansa
@ 2013-06-06 12:34 ` Martin Jansa
2013-06-11 8:08 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Martin Jansa @ 2013-06-06 12:34 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2345 bytes --]
On Sun, Jun 02, 2013 at 10:09:56AM +0200, Martin Jansa wrote:
> On Sat, Jun 01, 2013 at 08:03:22PM +0200, Martin Jansa wrote:
> > ---
> > ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
> > meta-efl/recipes-efl/webkit/webkit-efl_svn.bb | 3 +-
> > 2 files changed, 45 insertions(+), 1 deletion(-)
> > create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
>
> Ignore this one, it works on armv7a, but fails the same on armv4t and
> x86_64 + there is ICE when building for armv5te.
I've merged this in the end, because it fixed webkit-efl build on
jenkins (and it looks like building from scratch works for other archs
I'm building locally too).
Only remaining issue is with -O2 and xscalete DEFAULT_TUNE where it
triggers ICE:
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: In functi
on 'JSC::JSValue JSC::_ZN3JSCL6decodeEPNS_9ExecStateEPKcb.constprop.89(JSC::ExecState*, const char*)':
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: error: could not split insn
}
^
(insn 505 8094 507 (set (reg:SI 1 r1 [orig:494 D.142535 ] [494])
(plus:SI (reg/v:SI 5 r5 [orig:157 character ] [157])
(const_int -17179934720 [0xfffffffbffff0000]))) /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:108 5 {*arm_addsi3}
(nil))
/OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: internal compiler error: in final_scan_insn, at final.c:2897
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
{standard input}: Assembler messages:
{standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
Removing -O2 works, I'll check if this is still happening with gcc-4.8.1 when we have
recipes for it and report upstream if needed
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8
2013-06-06 12:34 ` Martin Jansa
@ 2013-06-11 8:08 ` Khem Raj
2013-06-11 8:42 ` Martin Jansa
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2013-06-11 8:08 UTC (permalink / raw)
To: openembeded-devel
On Thu, Jun 6, 2013 at 5:34 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Sun, Jun 02, 2013 at 10:09:56AM +0200, Martin Jansa wrote:
>> On Sat, Jun 01, 2013 at 08:03:22PM +0200, Martin Jansa wrote:
>> > ---
>> > ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
>> > meta-efl/recipes-efl/webkit/webkit-efl_svn.bb | 3 +-
>> > 2 files changed, 45 insertions(+), 1 deletion(-)
>> > create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
>>
>> Ignore this one, it works on armv7a, but fails the same on armv4t and
>> x86_64 + there is ICE when building for armv5te.
>
> I've merged this in the end, because it fixed webkit-efl build on
> jenkins (and it looks like building from scratch works for other archs
> I'm building locally too).
>
> Only remaining issue is with -O2 and xscalete DEFAULT_TUNE where it
> triggers ICE:
>
> /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: In functi
> on 'JSC::JSValue JSC::_ZN3JSCL6decodeEPNS_9ExecStateEPKcb.constprop.89(JSC::ExecState*, const char*)':
> /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: error: could not split insn
> }
> ^
> (insn 505 8094 507 (set (reg:SI 1 r1 [orig:494 D.142535 ] [494])
> (plus:SI (reg/v:SI 5 r5 [orig:157 character ] [157])
> (const_int -17179934720 [0xfffffffbffff0000]))) /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:108 5 {*arm_addsi3}
> (nil))
> /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: internal compiler error: in final_scan_insn, at final.c:2897
> Please submit a full bug report,
> with preprocessed source if appropriate.
> See <http://gcc.gnu.org/bugs.html> for instructions.
> {standard input}: Assembler messages:
> {standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
>
> Removing -O2 works, I'll check if this is still happening with gcc-4.8.1 when we have
> recipes for it and report upstream if needed
hmmm it needs to be reported. Can you generate preprocessed file and
put it somewhere accessible
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8
2013-06-11 8:08 ` Khem Raj
@ 2013-06-11 8:42 ` Martin Jansa
2013-06-11 8:44 ` Khem Raj
2013-06-27 15:58 ` Martin Jansa
0 siblings, 2 replies; 7+ messages in thread
From: Martin Jansa @ 2013-06-11 8:42 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2981 bytes --]
On Tue, Jun 11, 2013 at 01:08:13AM -0700, Khem Raj wrote:
> On Thu, Jun 6, 2013 at 5:34 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Sun, Jun 02, 2013 at 10:09:56AM +0200, Martin Jansa wrote:
> >> On Sat, Jun 01, 2013 at 08:03:22PM +0200, Martin Jansa wrote:
> >> > ---
> >> > ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
> >> > meta-efl/recipes-efl/webkit/webkit-efl_svn.bb | 3 +-
> >> > 2 files changed, 45 insertions(+), 1 deletion(-)
> >> > create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
> >>
> >> Ignore this one, it works on armv7a, but fails the same on armv4t and
> >> x86_64 + there is ICE when building for armv5te.
> >
> > I've merged this in the end, because it fixed webkit-efl build on
> > jenkins (and it looks like building from scratch works for other archs
> > I'm building locally too).
> >
> > Only remaining issue is with -O2 and xscalete DEFAULT_TUNE where it
> > triggers ICE:
> >
> > /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: In functi
> > on 'JSC::JSValue JSC::_ZN3JSCL6decodeEPNS_9ExecStateEPKcb.constprop.89(JSC::ExecState*, const char*)':
> > /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: error: could not split insn
> > }
> > ^
> > (insn 505 8094 507 (set (reg:SI 1 r1 [orig:494 D.142535 ] [494])
> > (plus:SI (reg/v:SI 5 r5 [orig:157 character ] [157])
> > (const_int -17179934720 [0xfffffffbffff0000]))) /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:108 5 {*arm_addsi3}
> > (nil))
> > /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: internal compiler error: in final_scan_insn, at final.c:2897
> > Please submit a full bug report,
> > with preprocessed source if appropriate.
> > See <http://gcc.gnu.org/bugs.html> for instructions.
> > {standard input}: Assembler messages:
> > {standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
> >
> > Removing -O2 works, I'll check if this is still happening with gcc-4.8.1 when we have
> > recipes for it and report upstream if needed
>
> hmmm it needs to be reported. Can you generate preprocessed file and
> put it somewhere accessible
I plan to, I just wanted to reproduce it with 4.8.1 and backported
http://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00784.html to see if it wasn't
fixed upstream already.
I guess we were all waiting for you to return from holidays and update
gcc to 4.8.1 :).
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8
2013-06-11 8:42 ` Martin Jansa
@ 2013-06-11 8:44 ` Khem Raj
2013-06-27 15:58 ` Martin Jansa
1 sibling, 0 replies; 7+ messages in thread
From: Khem Raj @ 2013-06-11 8:44 UTC (permalink / raw)
To: openembeded-devel
On Tue, Jun 11, 2013 at 1:42 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> I guess we were all waiting for you to return from holidays and update
> gcc to 4.8.1 :).
infact i do have 4.8.1 recipes cooking :)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8
2013-06-11 8:42 ` Martin Jansa
2013-06-11 8:44 ` Khem Raj
@ 2013-06-27 15:58 ` Martin Jansa
1 sibling, 0 replies; 7+ messages in thread
From: Martin Jansa @ 2013-06-27 15:58 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 3199 bytes --]
On Tue, Jun 11, 2013 at 10:42:04AM +0200, Martin Jansa wrote:
> On Tue, Jun 11, 2013 at 01:08:13AM -0700, Khem Raj wrote:
> > On Thu, Jun 6, 2013 at 5:34 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > > On Sun, Jun 02, 2013 at 10:09:56AM +0200, Martin Jansa wrote:
> > >> On Sat, Jun 01, 2013 at 08:03:22PM +0200, Martin Jansa wrote:
> > >> > ---
> > >> > ...include-Element.h-for-hasTagName-function.patch | 43 ++++++++++++++++++++++
> > >> > meta-efl/recipes-efl/webkit/webkit-efl_svn.bb | 3 +-
> > >> > 2 files changed, 45 insertions(+), 1 deletion(-)
> > >> > create mode 100644 meta-efl/recipes-efl/webkit/webkit-efl/0001-ewk-include-Element.h-for-hasTagName-function.patch
> > >>
> > >> Ignore this one, it works on armv7a, but fails the same on armv4t and
> > >> x86_64 + there is ICE when building for armv5te.
> > >
> > > I've merged this in the end, because it fixed webkit-efl build on
> > > jenkins (and it looks like building from scratch works for other archs
> > > I'm building locally too).
> > >
> > > Only remaining issue is with -O2 and xscalete DEFAULT_TUNE where it
> > > triggers ICE:
> > >
> > > /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: In functi
> > > on 'JSC::JSValue JSC::_ZN3JSCL6decodeEPNS_9ExecStateEPKcb.constprop.89(JSC::ExecState*, const char*)':
> > > /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: error: could not split insn
> > > }
> > > ^
> > > (insn 505 8094 507 (set (reg:SI 1 r1 [orig:494 D.142535 ] [494])
> > > (plus:SI (reg/v:SI 5 r5 [orig:157 character ] [157])
> > > (const_int -17179934720 [0xfffffffbffff0000]))) /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:108 5 {*arm_addsi3}
> > > (nil))
> > > /OE/shr-core/tmp-eglibc/work/xscalete-oe-linux-gnueabi/webkit-efl/1.9.3+svnr120144-r3/src/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:150:1: internal compiler error: in final_scan_insn, at final.c:2897
> > > Please submit a full bug report,
> > > with preprocessed source if appropriate.
> > > See <http://gcc.gnu.org/bugs.html> for instructions.
> > > {standard input}: Assembler messages:
> > > {standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive
> > >
> > > Removing -O2 works, I'll check if this is still happening with gcc-4.8.1 when we have
> > > recipes for it and report upstream if needed
> >
> > hmmm it needs to be reported. Can you generate preprocessed file and
> > put it somewhere accessible
>
> I plan to, I just wanted to reproduce it with 4.8.1 and backported
> http://gcc.gnu.org/ml/gcc-cvs/2013-03/msg00784.html to see if it wasn't
> fixed upstream already.
>
> I guess we were all waiting for you to return from holidays and update
> gcc to 4.8.1 :).
Done
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57735
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-06-27 15:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-01 18:03 [meta-efl][PATCH] webkit-efl: Fix build with gcc-4.8 Martin Jansa
2013-06-02 8:09 ` Martin Jansa
2013-06-06 12:34 ` Martin Jansa
2013-06-11 8:08 ` Khem Raj
2013-06-11 8:42 ` Martin Jansa
2013-06-11 8:44 ` Khem Raj
2013-06-27 15:58 ` Martin Jansa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox