From: Joe MacDonald <Joe.MacDonald@windriver.com>
To: <rongqing.li@windriver.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH meta-networking] quagga: two fixes
Date: Fri, 16 Aug 2013 13:17:02 -0400 [thread overview]
Message-ID: <20130816171702.GE13221@windriver.com> (raw)
In-Reply-To: <1376619839-23232-1-git-send-email-rongqing.li@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 2413 bytes --]
Merged, thanks.
-J.
[[PATCH meta-networking] quagga: two fixes] On 13.08.16 (Fri 10:23) rongqing.li@windriver.com wrote:
> From: "Roy.Li" <rongqing.li@windriver.com>
>
> 1. quagga should depend on iproute2, since ip from busybox is not sufficient
> 2. fix a typOS(should chmod, not chown)
>
> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
> ---
> meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
> index f5489c6..89b9f7a 100644
> --- a/meta-networking/recipes-protocols/quagga/quagga.inc
> +++ b/meta-networking/recipes-protocols/quagga/quagga.inc
> @@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \
> Quagga is a fork of GNU Zebra which was developed by Kunihiro \
> Ishiguro. The Quagga tree aims to build a more involved community \
> around Quagga than the current centralised model of GNU Zebra."
> -HOMEPAGE = "http://www.quagga.net/"
> +HOMEPAGE = "http://www.nongnu.org/quagga/"
> SECTION = "network"
> LICENSE = "GPL-2.0 & LGPL-2.0"
> DEPENDS = "readline ncurses perl-native"
> @@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>
> INC_PR = "r2"
>
> +# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes)
> +RDEPENDS_${PN} += "iproute2"
> +
> QUAGGASUBDIR = ""
> # ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old
> # versions and leave it empty for recent versions.
> @@ -128,11 +131,11 @@ pkg_postinst_${PN} () {
> if [ "x$D" != "x" ] ; then
> exit 1
> fi
> - for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> + for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
> chown quagga:quaggavty ${sysconfdir}/quagga
> chown quagga:quagga ${sysconfdir}/quagga/*.conf
> chmod 750 ${sysconfdir}/quagga
> - chown 640 ${sysconfdir}/quagga/*.conf
> + chmod 640 ${sysconfdir}/quagga/*.conf
> if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
> ${sysconfdir}/init.d/populate-volatile.sh update
> fi
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-08-16 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 2:23 [PATCH meta-networking] quagga: two fixes rongqing.li
2013-08-16 7:19 ` Martin Jansa
2013-08-16 8:44 ` Rongqing Li
2013-08-16 19:50 ` Martin Jansa
2013-08-16 17:17 ` Joe MacDonald [this message]
2013-09-05 13:28 ` Joe MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130816171702.GE13221@windriver.com \
--to=joe.macdonald@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=rongqing.li@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox