From: Rongqing Li <rongqing.li@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Cc: joe.macdonald@windriver.com
Subject: Re: [PATCH meta-networking] quagga: two fixes
Date: Fri, 16 Aug 2013 16:44:12 +0800 [thread overview]
Message-ID: <520DE65C.5050807@windriver.com> (raw)
In-Reply-To: <20130816071954.GG17945@jama>
On 08/16/2013 03:19 PM, Martin Jansa wrote:
> On Fri, Aug 16, 2013 at 10:23:59AM +0800, rongqing.li@windriver.com wrote:
>> From: "Roy.Li" <rongqing.li@windriver.com>
>>
>> 1. quagga should depend on iproute2, since ip from busybox is not sufficient
>> 2. fix a typOS(should chmod, not chown)
>
> As you care about quagga, can you please fix:
> quagga-0.99.21: The /usr/share/info/dir file is not meant to be shipped
> in a particular package.
>
> ?
I did not see this warning, and this file is shipped to quagga-doc.
If there is difference, it is in oe-core, not quagga
-Roy
>
> Thanks
>
>>
>> Signed-off-by: Roy.Li <rongqing.li@windriver.com>
>> ---
>> meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++---
>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc
>> index f5489c6..89b9f7a 100644
>> --- a/meta-networking/recipes-protocols/quagga/quagga.inc
>> +++ b/meta-networking/recipes-protocols/quagga/quagga.inc
>> @@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \
>> Quagga is a fork of GNU Zebra which was developed by Kunihiro \
>> Ishiguro. The Quagga tree aims to build a more involved community \
>> around Quagga than the current centralised model of GNU Zebra."
>> -HOMEPAGE = "http://www.quagga.net/"
>> +HOMEPAGE = "http://www.nongnu.org/quagga/"
>> SECTION = "network"
>> LICENSE = "GPL-2.0 & LGPL-2.0"
>> DEPENDS = "readline ncurses perl-native"
>> @@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>>
>> INC_PR = "r2"
>>
>> +# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes)
>> +RDEPENDS_${PN} += "iproute2"
>> +
>> QUAGGASUBDIR = ""
>> # ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old
>> # versions and leave it empty for recent versions.
>> @@ -128,11 +131,11 @@ pkg_postinst_${PN} () {
>> if [ "x$D" != "x" ] ; then
>> exit 1
>> fi
>> - for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
>> + for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done
>> chown quagga:quaggavty ${sysconfdir}/quagga
>> chown quagga:quagga ${sysconfdir}/quagga/*.conf
>> chmod 750 ${sysconfdir}/quagga
>> - chown 640 ${sysconfdir}/quagga/*.conf
>> + chmod 640 ${sysconfdir}/quagga/*.conf
>> if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then
>> ${sysconfdir}/init.d/populate-volatile.sh update
>> fi
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
--
Best Reagrds,
Roy | RongQing Li
next prev parent reply other threads:[~2013-08-16 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-16 2:23 [PATCH meta-networking] quagga: two fixes rongqing.li
2013-08-16 7:19 ` Martin Jansa
2013-08-16 8:44 ` Rongqing Li [this message]
2013-08-16 19:50 ` Martin Jansa
2013-08-16 17:17 ` Joe MacDonald
2013-09-05 13:28 ` Joe MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520DE65C.5050807@windriver.com \
--to=rongqing.li@windriver.com \
--cc=joe.macdonald@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox