From: Martin Jansa <martin.jansa@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][RFC] qtbase: fix build for gles2 enabled by PACKAGECONFIG
Date: Tue, 29 Oct 2013 08:07:36 +0100 [thread overview]
Message-ID: <20131029070736.GA3697@jama> (raw)
In-Reply-To: <1383001576-26578-1-git-send-email-schnitzeltony@googlemail.com>
[-- Attachment #1: Type: text/plain, Size: 2098 bytes --]
On Tue, Oct 29, 2013 at 12:06:15AM +0100, Andreas Müller wrote:
> While playing around with QtQuick I needed gles2 support. Doing so I faced tons
> of error messages as mentionet in patch. It is caused by include chain:
>
> EGL/egl.h -> EGL/eglplatform.h -> X11/Xlib.h -> X.h
>
> In X.h we find definitions like
>
> #ifndef None
> #define None 0L /* universal null resource or null atom */
> #endif
>
> This causes building Qt to crash when using these kind of symbols.
>
> The patch was sent as RFC because:
>
> 1. I would like ro discuss this at interest@qt-project.org and/or
> development@qt-project.org but it was not possible to subscribe. I sent
> a mail to listmaster but no response either.
> 2. qtbase_git might need same (and fails with the patch)
> 3. This is not a proper solution: It is fragile and will return for future
> changes. Proper soultion would be renaming the symbols Qt but I cannot
> discuss due to 1.
> 4. Nobody reported a build error for meta-qt5 so far.
We had similar problem, but fixed gles2 provider instead, in our case we
were using libhybris and the fix was to prevent loading X11 headers when
we want to use just gles2 from it.
Similar changes were added to mesa lately, can you do the same with
gles2 provider on your platform?
I must admit that I haven't read the patch yet and haven't finished
morning coffee :).
> Andreas Müller (1):
> qtbase: fix build for gles2 enabled by PACKAGECONFIG
>
> ...-reorder-includes-to-fix-build-with-eglfs.patch | 238 +++++++++++++++++++++
> recipes-qt/qt5/qtbase.inc | 1 +
> 2 files changed, 239 insertions(+)
> create mode 100644 recipes-qt/qt5/qtbase-5.1.1/0027-reorder-includes-to-fix-build-with-eglfs.patch
>
> --
> 1.8.3.1
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2013-10-29 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 23:06 [meta-qt5][RFC] qtbase: fix build for gles2 enabled by PACKAGECONFIG Andreas Müller
2013-10-28 23:06 ` Andreas Müller
2013-10-29 7:07 ` Martin Jansa [this message]
2013-10-29 8:14 ` Andreas Müller
2013-10-29 7:26 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029070736.GA3697@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox