Re: [meta-qt5][RFC] qtbase: fix build for gles2 enabled by PACKAGECONFIG

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2543 bytes --]

On Tue, Oct 29, 2013 at 09:14:09AM +0100, Andreas Müller wrote:
> On Tue, Oct 29, 2013 at 8:07 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Tue, Oct 29, 2013 at 12:06:15AM +0100, Andreas Müller wrote:
> >> While playing around with QtQuick I needed gles2 support. Doing so I faced tons
> >> of error messages as mentionet in patch. It is caused by include chain:
> >>
> >> EGL/egl.h -> EGL/eglplatform.h -> X11/Xlib.h -> X.h
> >>
> >> In X.h we find definitions like
> >>
> >> #ifndef None
> >> #define None                 0L       /* universal null resource or null atom */
> >> #endif
> >>
> >> This causes building Qt to crash when using these kind of symbols.
> >>
> >> The patch was sent as RFC because:
> >>
> >> 1.  I would like ro discuss this at interest@qt-project.org and/or
> >>     development@qt-project.org but it was not possible to subscribe. I sent
> >>     a mail to listmaster but no response either.
> >> 2.  qtbase_git might need same (and fails with the patch)
> >> 3.  This is not a proper solution: It is fragile and will return for future
> >>     changes. Proper soultion would be renaming the symbols Qt but I cannot
> >>     discuss due to 1.
> >> 4.  Nobody reported a build error for meta-qt5 so far.
> >
> > We had similar problem, but fixed gles2 provider instead, in our case we
> > were using libhybris and the fix was to prevent loading X11 headers when
> > we want to use just gles2 from it.
> >
> > Similar changes were added to mesa lately, can you do the same with
> > gles2 provider on your platform?
> It is the egl part causing trouble and the headers we use are the
> latest from khronos. I don't understand what the workaround exactly
> looks like - could you provide further hints?

Something like this:
https://github.com/stskeeps/libhybris/commit/6b2815973f98601e39d916a8f53a4f6acb76b22b

or directly in mesa:
http://git.openembedded.org/openembedded-core/commit/meta/recipes-graphics/mesa/mesa?h=dylan&id=e4f5a568ec8df772f2b8c07f2ac946b2e9247ccd
or newer versions:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1a7275de9a0088cedab17131eec82bd2cada26c3

> >
> > I must admit that I haven't read the patch yet and haven't finished
> > morning coffee :).
> >
> Andreas
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]