[meta-oe][PATCH] utouch-mtview: Add missing dependency to libx11

[meta-oe][PATCH] utouch-mtview: Add missing dependency to libx11

[Samuel Stirtzel]

Also added RDEPENDS to virtual/xserver since this program cannot be used without X

Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
---
 .../recipes-support/utouch/utouch-mtview_git.bb    |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/utouch/utouch-mtview_git.bb b/meta-oe/recipes-support/utouch/utouch-mtview_git.bb
index 0f72479..973d509 100644
--- a/meta-oe/recipes-support/utouch/utouch-mtview_git.bb
+++ b/meta-oe/recipes-support/utouch/utouch-mtview_git.bb
@@ -10,7 +10,9 @@ inherit autotools
 SRC_URI = "git://bitmath.org/git/mtview.git;protocol=http"
 SRCREV = "ad437c38dc111cf3990a03abf14efe1b5d89604b"
 
-DEPENDS += "mtdev utouch-frame utouch-evemu"
+DEPENDS += "mtdev utouch-frame utouch-evemu libx11"
+
+RDEPENDS += "virtual/xserver"
 
 PV = "1.1.7+git${SRCPV}"
 
-- 
1.7.9.5

Re: [meta-oe][PATCH] utouch-mtview: Add missing dependency to libx11

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

On Tue, Oct 29, 2013 at 04:46:03PM +0100, Samuel Stirtzel wrote:
> Also added RDEPENDS to virtual/xserver since this program cannot be used without X
> 
> Signed-off-by: Samuel Stirtzel <s.stirtzel@googlemail.com>
> ---
>  .../recipes-support/utouch/utouch-mtview_git.bb    |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/utouch/utouch-mtview_git.bb b/meta-oe/recipes-support/utouch/utouch-mtview_git.bb
> index 0f72479..973d509 100644
> --- a/meta-oe/recipes-support/utouch/utouch-mtview_git.bb
> +++ b/meta-oe/recipes-support/utouch/utouch-mtview_git.bb
> @@ -10,7 +10,9 @@ inherit autotools
>  SRC_URI = "git://bitmath.org/git/mtview.git;protocol=http"
>  SRCREV = "ad437c38dc111cf3990a03abf14efe1b5d89604b"
>  
> -DEPENDS += "mtdev utouch-frame utouch-evemu"
> +DEPENDS += "mtdev utouch-frame utouch-evemu libx11"
> +
> +RDEPENDS += "virtual/xserver"

1) it's RDEPENDS_${PN}
2) you cannot use virtual/foo for runtime dependencies - use
VIRTUAL-RUNTIME_foo (in this case it doesn't work well use XSERVER
variable or packagegroup-core-x11-xserver or just drop it and let
user to do the right thing - I think we have a lot of x11 apps without
this runtime dependency explicitly set).

>  
>  PV = "1.1.7+git${SRCPV}"
>  
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]