Re: [meta-oe][PATCH 5/7] gtkperf: Create 0.40 version

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3535 bytes --]

On Fri, Mar 07, 2014 at 03:26:13PM -0600, Lauren Post wrote:
> gtkperf is a GTK Performance tool
> 
> Signed-off-by: Lauren Post <lauren.post@freescale.com>
> ---
>  meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars |   25 ++++++++++++++++++++
>  meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb  |   26 +++++++++++++++++++++
>  2 files changed, 51 insertions(+)
>  create mode 100644 meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
>  create mode 100644 meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
> 
> diff --git a/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars b/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
> new file mode 100644
> index 0000000..8b09f53
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/gtkperf/gtkperf/Makevars
> @@ -0,0 +1,25 @@
> +# Makefile variables for PO directory in any package using GNU gettext.
> +
> +# Usually the message domain is the same as the package name.
> +DOMAIN = $(PACKAGE)
> +
> +# These two variables depend on the location of this directory.
> +subdir = po
> +top_builddir = ..
> +
> +# These options get passed to xgettext.
> +XGETTEXT_OPTIONS = --keyword=_ --keyword=N_
> +
> +# This is the copyright holder that gets inserted into the header of the
> +# $(DOMAIN).pot file.  Set this to the copyright holder of the surrounding
> +# package.  (Note that the msgstr strings, extracted from the package's
> +# sources, belong to the copyright holder of the package.)  Translators are
> +# expected to transfer the copyright for their translations to this person
> +# or entity, or to disclaim their copyright.  The empty string stands for
> +# the public domain; in this case the translators are expected to disclaim
> +# their copyright.
> +COPYRIGHT_HOLDER = Free Software Foundation, Inc.
> +
> +# This is the list of locale categories, beyond LC_MESSAGES, for which the
> +# message catalogs shall be used.  It is usually empty.
> +EXTRA_LOCALE_CATEGORIES =
> diff --git a/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb b/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
> new file mode 100644
> index 0000000..7e97a11
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/gtkperf/gtkperf_0.40.bb
> @@ -0,0 +1,26 @@
> +SUMMARY = "GTK Performance tool"
> +DESCRIPTION = "GTK Performance tools"

Don't duplicate SUMMARY (extra 's' doesn't count)

> +SECTION = "libs"
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
> +
> +SRC_URI = "http://prdownloads.sourceforge.net/gtkperf/gtkperf_${PV}.tar.gz \

gtkperf -> ${BPN}

> +           file://Makevars"
> +
> +SRC_URI[md5sum] = "4331dde4bb83865e15482885fcb0cc53"
> +SRC_URI[sha256sum] = "9704344e732038eecbd007dd996a56293a6b027b5b76f3f036273a3fae1ab27b"
> +
> +S = "${WORKDIR}/gtkperf"

gtkperf -> ${BPN}

> +
> +inherit autotools binconfig pkgconfig gettext
> +
> +do_configure_prepend () {
> +	rm -f ${S}/m4/init.m4
> +	cp -f ${WORKDIR}/Makevars ${S}/po/

Please use consistent indentation: tab -> 4 spaces

> +}
> +
> +do_install_append () {
> +     rm -rf ${WORKDIR}/image/usr/doc

Please use consistent indentation: 5 spaces -> 4 spaces

${WORKDIR}/image -> ${D}

> +}
> +
> +FILES_${PN} += "${exec_prefix}/share/duck.png"

${exec_prefix}/share -> ${datadir}

I've made above modifications when cherry-picking from patchwork to
master-next, so don't send v2 (unless you need to change something else
as well)

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]