[meta-oe][PATCH] rsnapshot: make this an allarch package

[meta-oe][PATCH] rsnapshot: make this an allarch package

[André Draszik]

From: André Draszik <git@andred.net>

rsnapshot is just some perl script(s), no machine specific binaries.
---
 meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb b/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
index d680511..0593eef 100644
--- a/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
+++ b/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
@@ -29,7 +29,7 @@ SRC_URI = "git://github.com/DrHyde/${BPN};branch=master;protocol=git \
 
 S = "${WORKDIR}/git"
 
-inherit autotools
+inherit allarch autotools
 
 # Fix rsnapshot.conf.default:
 # don't inject the host path into target configs.
-- 
2.1.4

Re: [meta-oe][PATCH] rsnapshot: make this an allarch package

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On Fri, Jul 24, 2015 at 02:18:21PM +0100, André Draszik wrote:
> From: André Draszik <git@andred.net>
> 
> rsnapshot is just some perl script(s), no machine specific binaries.

NAK

The recipe has bunch of RDEPENDS on TUNE_PKGARCH recipes so it cannot be
allarch.

Recipe by default is TUNE_PKGARCH not MACHINE_ARCH as commit message may
suggest.

> ---
>  meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb b/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
> index d680511..0593eef 100644
> --- a/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
> +++ b/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
> @@ -29,7 +29,7 @@ SRC_URI = "git://github.com/DrHyde/${BPN};branch=master;protocol=git \
>  
>  S = "${WORKDIR}/git"
>  
> -inherit autotools
> +inherit allarch autotools
>  
>  # Fix rsnapshot.conf.default:
>  # don't inject the host path into target configs.
> -- 
> 2.1.4
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-oe][PATCH] rsnapshot: make this an allarch package

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]


> On Jul 27, 2015, at 9:34 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> 
> On Fri, Jul 24, 2015 at 02:18:21PM +0100, André Draszik wrote:
>> From: André Draszik <git@andred.net>
>> 
>> rsnapshot is just some perl script(s), no machine specific binaries.
> 
> NAK
> 
> The recipe has bunch of RDEPENDS on TUNE_PKGARCH recipes so it cannot be
> allarch.
> 
> Recipe by default is TUNE_PKGARCH not MACHINE_ARCH as commit message may
> suggest.


I understand the NAK since it has runtime dependencies on binary compiled programs like rsync which are architecture dependent
due to different ISA and so on. However, from another perspective, its a script which is invoking/executing a standard utility
much like its own interpreter say bash or perl whichever it needs and bash, perl etc. are natively compiled binaries. going by this logic
we can really not have allarch package at all. So IMO runtime dependencies
for script based packages should not bar it from being a allarch package. Since, I can still take the same ipk and install it on arm or mips
and it will work as long as they provide its dependencies like rsync perl etc.

> 
>> ---
>> meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb b/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
>> index d680511..0593eef 100644
>> --- a/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
>> +++ b/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
>> @@ -29,7 +29,7 @@ SRC_URI = "git://github.com/DrHyde/${BPN};branch=master;protocol=git \
>> 
>> S = "${WORKDIR}/git"
>> 
>> -inherit autotools
>> +inherit allarch autotools
>> 
>> # Fix rsnapshot.conf.default:
>> # don't inject the host path into target configs.
>> --
>> 2.1.4
>> 
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [meta-oe][PATCH] rsnapshot: make this an allarch package

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3198 bytes --]

On Sat, Aug 08, 2015 at 03:39:07PM -0700, Khem Raj wrote:
> 
> > On Jul 27, 2015, at 9:34 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > 
> > On Fri, Jul 24, 2015 at 02:18:21PM +0100, André Draszik wrote:
> >> From: André Draszik <git@andred.net>
> >> 
> >> rsnapshot is just some perl script(s), no machine specific binaries.
> > 
> > NAK
> > 
> > The recipe has bunch of RDEPENDS on TUNE_PKGARCH recipes so it cannot be
> > allarch.
> > 
> > Recipe by default is TUNE_PKGARCH not MACHINE_ARCH as commit message may
> > suggest.
> 
> 
> I understand the NAK since it has runtime dependencies on binary compiled programs like rsync which are architecture dependent
> due to different ISA and so on. However, from another perspective, its a script which is invoking/executing a standard utility
> much like its own interpreter say bash or perl whichever it needs and bash, perl etc. are natively compiled binaries. going by this logic
> we can really not have allarch package at all. So IMO runtime dependencies
> for script based packages should not bar it from being a allarch package. Since, I can still take the same ipk and install it on arm or mips
> and it will work as long as they provide its dependencies like rsync perl etc.

With current sstate checksum generators accepting this will cause all
these "allarch" recipes to be "rebuilt" (from sstate) every time you change
MACHINE to something with different TUNE_PKGARCH.

Keeping it TUNE_PKGARCH means that you'll always get exactly the same
package from feed (not the last one "built" randomly changing when
builder builds different MACHINEs in a loop).

> 
> > 
> >> ---
> >> meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb b/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
> >> index d680511..0593eef 100644
> >> --- a/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
> >> +++ b/meta-oe/recipes-support/rsnapshot/rsnapshot_git.bb
> >> @@ -29,7 +29,7 @@ SRC_URI = "git://github.com/DrHyde/${BPN};branch=master;protocol=git \
> >> 
> >> S = "${WORKDIR}/git"
> >> 
> >> -inherit autotools
> >> +inherit allarch autotools
> >> 
> >> # Fix rsnapshot.conf.default:
> >> # don't inject the host path into target configs.
> >> --
> >> 2.1.4
> >> 
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > 
> > --
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 



> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]