[meta-qt5][PATCH] qtbase: fix QA warning of host uid leakage

[meta-qt5][PATCH] qtbase: fix QA warning of host uid leakage

[Anders Darander]

Two files in /usr/lib, were own by the uid of the build process.

Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 recipes-qt/qt5/qtbase_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_git.bb
index 39d02a9..99ac208 100644
--- a/recipes-qt/qt5/qtbase_git.bb
+++ b/recipes-qt/qt5/qtbase_git.bb
@@ -232,6 +232,8 @@ do_install_append() {
         chown -R root:root ${D}/${OE_QMAKE_PATH_QT_FONTS}
     fi
     cp -a ${B}/lib/libqt* ${D}${libdir}
+    chown root:root ${D}${libdir}/libqtpcre.prl
+    chown root:root ${D}${libdir}/libqtpcre.a
     # Remove example.pro file as it is useless
     rm -f ${D}${OE_QMAKE_PATH_EXAMPLES}/examples.pro
 
-- 
2.6.1

Re: [meta-qt5][PATCH] qtbase: fix QA warning of host uid leakage

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]

On Thu, Oct 15, 2015 at 08:21:27PM +0200, Anders Darander wrote:
> Two files in /usr/lib, were own by the uid of the build process.
> 
> Signed-off-by: Anders Darander <anders@chargestorm.se>
> ---
>  recipes-qt/qt5/qtbase_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_git.bb
> index 39d02a9..99ac208 100644
> --- a/recipes-qt/qt5/qtbase_git.bb
> +++ b/recipes-qt/qt5/qtbase_git.bb
> @@ -232,6 +232,8 @@ do_install_append() {
>          chown -R root:root ${D}/${OE_QMAKE_PATH_QT_FONTS}
>      fi
>      cp -a ${B}/lib/libqt* ${D}${libdir}

Can we use install instead of cp to resolve this issue instead of chmod?

> +    chown root:root ${D}${libdir}/libqtpcre.prl
> +    chown root:root ${D}${libdir}/libqtpcre.a
>      # Remove example.pro file as it is useless
>      rm -f ${D}${OE_QMAKE_PATH_EXAMPLES}/examples.pro
>  
> -- 
> 2.6.1
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-qt5][PATCH] qtbase: fix QA warning of host uid leakage

[Anders Darander]

* Martin Jansa <martin.jansa@gmail.com> [151015 21:48]:

> On Thu, Oct 15, 2015 at 08:21:27PM +0200, Anders Darander wrote:
> > Two files in /usr/lib, were own by the uid of the build process.

> > Signed-off-by: Anders Darander <anders@chargestorm.se>
> > ---
> >  recipes-qt/qt5/qtbase_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)

> > diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_git.bb
> > index 39d02a9..99ac208 100644
> > --- a/recipes-qt/qt5/qtbase_git.bb
> > +++ b/recipes-qt/qt5/qtbase_git.bb
> > @@ -232,6 +232,8 @@ do_install_append() {
> >          chown -R root:root ${D}/${OE_QMAKE_PATH_QT_FONTS}
> >      fi
> >      cp -a ${B}/lib/libqt* ${D}${libdir}

> Can we use install instead of cp to resolve this issue instead of chmod?

Well, that was my first idea too. Though, to be honest, I never looked
into how many files were covered by the cp command.

At least with my minimal configuration Qt, it's only the two files below
that gets copied. So I'll respin the patch to use install instead.

Do you, or someone else know if there are occasions were more than the
two file belows matches ${B}/lib/libqt*?

Cheers,
Anders

> > +    chown root:root ${D}${libdir}/libqtpcre.prl
> > +    chown root:root ${D}${libdir}/libqtpcre.a
> >      # Remove example.pro file as it is useless
> >      rm -f ${D}${OE_QMAKE_PATH_EXAMPLES}/examples.pro
-- 
Anders Darander
ChargeStorm AB / eStorm AB