Re: [meta-qt5] [PATCH] qttools: DEPENDS on icu

[Denys Dmytriyenko <denis@denix.org>]

On Tue, Jun 20, 2017 at 06:28:32AM +0200, liu.ming50@gmail.com wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
> 
> This fixes a following QA issue:
> | QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicui18n, but it isn't a build dependency.
> | QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc, but it isn't a build dependency.
> | QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicudata, but it isn't a build dependency.

It seems there's inconsistency here between errors above referring to 
nativesdk-qtbase-tools and the change below made to qttools instead of 
qtbase!

I wonder if this fix was not included by the author:

https://github.com/meta-qt5/meta-qt5/commit/ff073f04109900fc07bf81e2f1df63c626caf342

Just to double-check, I just built nativesdk-qttools using meta-qt5 w/o this 
patch and I don't see the above QA errors.

-- 
Denys


> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
>  recipes-qt/qt5/qttools_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-qt/qt5/qttools_git.bb b/recipes-qt/qt5/qttools_git.bb
> index 5c0f51c..1108390 100644
> --- a/recipes-qt/qt5/qttools_git.bb
> +++ b/recipes-qt/qt5/qttools_git.bb
> @@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
>  
>  inherit ptest
>  
> -DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
> +DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
>  
>  SRC_URI += " \
>      file://run-ptest \
> -- 
> 2.7.4
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel