Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Ming Liu <peter.x.liu@external.atlascopco.com>,
	openembedded-devel <openembedded-devel@lists.openembedded.org>,
	Ming Liu <liu.ming50@gmail.com>
Subject: Re: [meta-qt5] [PATCH] qttools: DEPENDS on icu
Date: Fri, 23 Jun 2017 17:46:32 -0400	[thread overview]
Message-ID: <20170623214631.GC28053@denix.org> (raw)
In-Reply-To: <CA+chaQeXfn18+4zHth7_enazNF9hh3idLT+V7YvJLPH+5p5cQw@mail.gmail.com>

Thanks.

On Fri, Jun 23, 2017 at 11:41:05PM +0200, Martin Jansa wrote:
> Yes, I've seen both e-mails. I'm waiting for response from author, then
> I'll revert it in master and pyro branches.
> 
> On Fri, Jun 23, 2017 at 11:19 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> 
> > Martin,
> >
> > Were you able to look into this yet? I didn't copy you directly at first,
> > so
> > not sure if you missed it...
> >
> >
> > On Thu, Jun 22, 2017 at 03:18:49PM -0400, Denys Dmytriyenko wrote:
> > > On Tue, Jun 20, 2017 at 06:28:32AM +0200, liu.ming50@gmail.com wrote:
> > > > From: Ming Liu <peter.x.liu@external.atlascopco.com>
> > > >
> > > > This fixes a following QA issue:
> > > > | QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicui18n,
> > but it isn't a build dependency.
> > > > | QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicuuc, but
> > it isn't a build dependency.
> > > > | QA Issue: nativesdk-qtbase-tools rdepends on nativesdk-libicudata,
> > but it isn't a build dependency.
> > >
> > > It seems there's inconsistency here between errors above referring to
> > > nativesdk-qtbase-tools and the change below made to qttools instead of
> > > qtbase!
> > >
> > > I wonder if this fix was not included by the author:
> > >
> > > https://github.com/meta-qt5/meta-qt5/commit/
> > ff073f04109900fc07bf81e2f1df63c626caf342
> > >
> > > Just to double-check, I just built nativesdk-qttools using meta-qt5 w/o
> > this
> > > patch and I don't see the above QA errors.
> > >
> > > --
> > > Denys
> > >
> > >
> > > > Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> > > > ---
> > > >  recipes-qt/qt5/qttools_git.bb | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/recipes-qt/qt5/qttools_git.bb b/recipes-qt/qt5/
> > qttools_git.bb
> > > > index 5c0f51c..1108390 100644
> > > > --- a/recipes-qt/qt5/qttools_git.bb
> > > > +++ b/recipes-qt/qt5/qttools_git.bb
> > > > @@ -16,7 +16,7 @@ LIC_FILES_CHKSUM = " \
> > > >
> > > >  inherit ptest
> > > >
> > > > -DEPENDS += "qtbase qtdeclarative qtxmlpatterns"
> > > > +DEPENDS += "qtbase qtdeclarative qtxmlpatterns icu"
> > > >
> > > >  SRC_URI += " \
> > > >      file://run-ptest \
> > > > --
> > > > 2.7.4
> > > >
> > > > --
> > > > _______________________________________________
> > > > Openembedded-devel mailing list
> > > > Openembedded-devel@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >


  reply	other threads:[~2017-06-23 21:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20  4:28 [meta-qt5] [PATCH] qttools: DEPENDS on icu liu.ming50
2017-06-22 19:18 ` Denys Dmytriyenko
2017-06-23 21:19   ` Denys Dmytriyenko
2017-06-23 21:41     ` Martin Jansa
2017-06-23 21:46       ` Denys Dmytriyenko [this message]
     [not found]         ` <CALatG=7jn597sL8XE2hk8X67smJTH84HPe+wsYzwHC1HNHh9cA@mail.gmail.com>
2017-06-26 15:52           ` Denys Dmytriyenko
2017-06-27  3:04             ` Ming Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170623214631.GC28053@denix.org \
    --to=denis@denix.org \
    --cc=liu.ming50@gmail.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=peter.x.liu@external.atlascopco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox