[meta-oe] [PATCH v2 1/1] fio: remove disabling of compiler optimizations

[meta-oe] [PATCH v2 1/1] fio: remove disabling of compiler optimizations

[Jonathan Richardson]

Disabling compiler optimizations affects fio performance by 25-30% so
remove this from EXTRA_OECONF. Disabling of optimizations should be
machine specific if there are bugs in the code instead of the default.

Optimizations were removed in this commit:
https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea

Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
---
 meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-oe/recipes-benchmark/fio/fio_3.18.bb b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
index b6484290f..2c461b8c5 100644
--- a/meta-oe/recipes-benchmark/fio/fio_3.18.bb
+++ b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
@@ -33,7 +33,6 @@ S = "${WORKDIR}/git"
 DISABLE_STATIC = ""
 
 EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
-EXTRA_OECONF = "--disable-optimizations"
 
 do_configure() {
     ./configure ${EXTRA_OECONF}
-- 
2.17.1

Re: [meta-oe] [PATCH v2 1/1] fio: remove disabling of compiler optimizations

[Khem Raj]

On Tue, Feb 18, 2020 at 1:08 PM Jonathan Richardson via
Openembedded-devel <openembedded-devel@lists.openembedded.org> wrote:
>
> Disabling compiler optimizations affects fio performance by 25-30% so
> remove this from EXTRA_OECONF. Disabling of optimizations should be
> machine specific if there are bugs in the code instead of the default.
>
> Optimizations were removed in this commit:
> https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea
>
> Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> ---
>  meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta-oe/recipes-benchmark/fio/fio_3.18.bb b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> index b6484290f..2c461b8c5 100644
> --- a/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> +++ b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> @@ -33,7 +33,6 @@ S = "${WORKDIR}/git"
>  DISABLE_STATIC = ""
>
>  EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
> -EXTRA_OECONF = "--disable-optimizations"
>

I think Mingli disabled it and I would like to get his feedback before
we revert this change

>  do_configure() {
>      ./configure ${EXTRA_OECONF}
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel