Openembedded Devel Discussions
 help / color / mirror / Atom feed
* [PATCH 1/2] cups-filters: remove duplicate configure option
@ 2023-03-09 17:16 Trevor Woerner
  2023-03-09 17:16 ` [PATCH 2/2] cups-filters: fix ghostscript handling Trevor Woerner
  0 siblings, 1 reply; 2+ messages in thread
From: Trevor Woerner @ 2023-03-09 17:16 UTC (permalink / raw)
  To: openembedded-devel

The '--enable-ghostscript' configure option is specified twice and doesn't
need to be. It's simply a boolean; it's not the sort of option whose position
is relevant, or an option which modifies its immediate neighbours.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb b/meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb
index 22de3d544127..0d3560b9c2ac 100644
--- a/meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb
+++ b/meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb
@@ -15,7 +15,7 @@ SRC_URI[sha256sum] = "270a3752a960368aa99d431fb5d34f4039b2ac943c576d840612d1d818
 
 inherit autotools-brokensep gettext pkgconfig github-releases
 
-EXTRA_OECONF += " --enable-ghostscript --disable-ldap \
+EXTRA_OECONF += " --disable-ldap \
                        --with-pdftops=hybrid --enable-imagefilters \
                        --enable-ghostscript --with-gs-path=${bindir}/gs \
                        --with-pdftops-path=${bindir}/gs \
-- 
2.36.0.rc2.17.g4027e30c53



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 2/2] cups-filters: fix ghostscript handling
  2023-03-09 17:16 [PATCH 1/2] cups-filters: remove duplicate configure option Trevor Woerner
@ 2023-03-09 17:16 ` Trevor Woerner
  0 siblings, 0 replies; 2+ messages in thread
From: Trevor Woerner @ 2023-03-09 17:16 UTC (permalink / raw)
  To: openembedded-devel

ghostscript is not needed at build-time (it only needs to be enabled in the
configuration step) but it is required at run-time for two of this recipe's
packages.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb b/meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb
index 0d3560b9c2ac..fd82bb39c2d4 100644
--- a/meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb
+++ b/meta-oe/recipes-printing/cups/cups-filters_1.28.17.bb
@@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=2d77679ce6a2cc4d873d4ebbf2a401e6"
 
 SECTION = "console/utils"
 
-DEPENDS = "cups glib-2.0 glib-2.0-native dbus dbus-glib lcms ghostscript poppler qpdf libpng libexif"
+DEPENDS = "cups glib-2.0 glib-2.0-native dbus dbus-glib lcms poppler qpdf libpng libexif"
 DEPENDS:class-native = "poppler-native glib-2.0-native dbus-native pkgconfig-native gettext-native libpng-native"
 
 SRC_URI = "https://github.com/OpenPrinting/${BPN}/releases/download/${PV}/${BP}.tar.xz \
@@ -51,6 +51,7 @@ PACKAGES =+ "\
 FILES:${PN}-gst = "\
 	${libexecdir}/cups/filter/gsto* \
 	"
+RDEPENDS:${PN}-gst += "ghostscript"
 
 FILES:${PN}-data = "\
 	${datadir}/cups/data \
@@ -71,6 +72,8 @@ FILES:${PN} += "\
         ${datadir}/cups/ppdc \
         ${datadir}/cups/banners \
 "
+RDEPENDS:${PN} += "bash"
+RDEPENDS:${PN} += "ghostscript"
 
 do_install:append() {
 	# remove braille dir
@@ -79,5 +82,3 @@ do_install:append() {
 	# remove sysroot path contamination from pkgconfig file
 	sed -i -e 's:${STAGING_DIR_TARGET}::' ${D}/${libdir}/pkgconfig/libcupsfilters.pc
 }
-
-RDEPENDS:${PN} += "bash"
-- 
2.36.0.rc2.17.g4027e30c53



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-09 17:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-09 17:16 [PATCH 1/2] cups-filters: remove duplicate configure option Trevor Woerner
2023-03-09 17:16 ` [PATCH 2/2] cups-filters: fix ghostscript handling Trevor Woerner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox