Re: [meta-kde][PATCH] qt4-x11-free 4.8.0 bbappend: fix GLES configure switch and turn it on for AM335x SoCs as well

[Paul Eggleton <paul.eggleton@linux.intel.com>]

On Monday 23 April 2012 21:39:36 Koen Kooi wrote:
> Op 23-04-12 17:46, Paul Eggleton schreef:
> > On Monday 23 April 2012 16:25:35 Koen Kooi wrote:
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> ---
> >> recipes-misc-support/qt4-x11-free_4.8.0.bbappend |    5 +++-- 1 files
> >> changed, 3 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/recipes-misc-support/qt4-x11-free_4.8.0.bbappend
> >> b/recipes-misc-support/qt4-x11-free_4.8.0.bbappend index
> >> b5a3c16..4895893 100644 ---
> >> a/recipes-misc-support/qt4-x11-free_4.8.0.bbappend +++
> >> b/recipes-misc-support/qt4-x11-free_4.8.0.bbappend @@ -1,7 +1,8 @@
> >> -QT_GLFLAGS_omap3 = "-egl" +QT_GLFLAGS_omap3 = "-opengl es2 "
> >> DEPENDS_append_omap3 = " libgles-omap3" +DEPENDS_append_ti33x = "
> >> libgles-omap3"
> >> 
> >> # Needed by kdelibs QT_DISTRO_FLAGS = "-accessibility -sm"
> >> 
> >> -PRINC := "${@int(PRINC) + 1}" \ No newline at end of file +PRINC :=
> >> "${@int(PRINC) + 2}"
> > 
> > Can we avoid this machine-specific stuff creeping into software layers?
> > At least in this case we're appending something in OE-Core so there
> > should be no problem with this appearing in an append in the BSP(s).
> 
> Have a look at what was discussed in the "[meta-kde] Test images (was: Re:
> [OE-core] RFC: Porting KDE Plasma Active (WIP))" thread

Yes, I understand why it was added, but (as I'm sure you're aware) one of the 
reasons why we did the layer split was to avoid having numbers of machine-
specific overrides appearing in generic recipes.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre