Patches to svn based recipes

Patches to svn based recipes

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Could people please stop doing stuff like:

openmoko-panel-bt_svn.bb: Drop panel-bluetooth.patch, as it was applied upstream
# delete "packages/openmoko-panel-plugins/files/panel-bluetooth.patch"

openmoko-dialer2_svn.bb : patch is now applied upstream
- -SRC_URI += "file://openmoko-dialer.patch;patch=1"

matchbox-keyboard: Bump svn revision and remove some patches in the bb file
since these patches were applied upstream.
- -        file://matchbox-keyboard-applet.patch;patch=1;pnum=0 \
- -	file://matchbox-keyboard-hide-delay.patch;patch=1"

And use ;minrev= and ;maxrev=. Removing patches makes regression testing and building
older versions impossible.

thanks,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFHFJrgMkyGM64RGpERApMOAKClM/Zq0/AdWjCp42e+17C90OFnSgCfWIo6
Jnt6HjpEr2q2cJGKueJ1vUs=
=675J
-----END PGP SIGNATURE-----

Re: Patches to svn based recipes

[Philippe De Swert]

Hi all!


> Could people please stop doing stuff like:
>
> openmoko-panel-bt_svn.bb: Drop panel-bluetooth.patch, as it was applied upstream
> # delete "packages/openmoko-panel-plugins/files/panel-bluetooth.patch"
>
> openmoko-dialer2_svn.bb : patch is now applied upstream
> - -SRC_URI += "file://openmoko-dialer.patch;patch=1"
>
> matchbox-keyboard: Bump svn revision and remove some patches in the bb file
> since these patches were applied upstream.
> - -        file://matchbox-keyboard-applet.patch;patch=1;pnum=0 \
> - -	file://matchbox-keyboard-hide-delay.patch;patch=1"
>
> And use ;minrev= and ;maxrev=. Removing patches makes regression testing and
building
> older versions impossible.

Ok. So all those things are forbidden. Good. So what are we expected to write
in the commit message then? It is usually much more useful to also specify the
expected behaviour when listing the unwanted one.

Thanks,

Philippe
---
Scarlet One, ADSL 6 Mbps + Telephone, from EUR 29,95...
http://www.scarlet.be/

Re: Patches to svn based recipes

[Marcin Juszkiewicz]

Dnia wtorek, 16 października 2007, Philippe De Swert napisał:

> > And use ;minrev= and ;maxrev=. Removing patches makes regression
> > testing and building older versions impossible.

> Ok. So all those things are forbidden. Good. So what are we expected to
> write in the commit message then? 

"openmoko-dialer2: openmoko-dialer.patch got included upstream"

-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

              whats mean ubuntu?
              it's african word for "can't configure debian"

Re: Patches to svn based recipes

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philippe De Swert schreef:
> Hi all!
> 
> 
>> Could people please stop doing stuff like:
>>
>> openmoko-panel-bt_svn.bb: Drop panel-bluetooth.patch, as it was applied upstream
>> # delete "packages/openmoko-panel-plugins/files/panel-bluetooth.patch"
>>
>> openmoko-dialer2_svn.bb : patch is now applied upstream
>> - -SRC_URI += "file://openmoko-dialer.patch;patch=1"
>>
>> matchbox-keyboard: Bump svn revision and remove some patches in the bb file
>> since these patches were applied upstream.
>> - -        file://matchbox-keyboard-applet.patch;patch=1;pnum=0 \
>> - -	file://matchbox-keyboard-hide-delay.patch;patch=1"
>>
>> And use ;minrev= and ;maxrev=. Removing patches makes regression testing and
> building
>> older versions impossible.
> 
> Ok. So all those things are forbidden. Good. So what are we expected to write
> in the commit message then?

Write what you want in the commit message, as long as you update the SRC_URI to use
;minrev= and ;maxrev=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFHFOI/MkyGM64RGpERAvwmAKCDYxlc2fi/PWu2VI2KUu1/+GLI+QCeIWML
c6rJKitTc4u90z2FiSbQt44=
=vqS+
-----END PGP SIGNATURE-----