Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: "Jeremy Lainé" <jeremy.laine@bolloretelecom.eu>
To: openembedded-devel@lists.openembedded.org
Subject: [RFC] make "LDFLAGS ignored" QA errors fatal
Date: Mon, 06 Apr 2009 18:34:52 +0200	[thread overview]
Message-ID: <49DA2F2C.60008@bolloretelecom.eu> (raw)

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I have spent quite some time cleaning up a bunch of recipes which were
triggering "LDFLAGS ignored" QA errors, and I don't really want to
have to do this again in the future. I suggest we stop whitelisting
this kind of QA error, using the attached patch.

To track down the faulty packages I have made use of oestats output
(note that not all QA errors are "LDFLAGS ignored"):

http://tinderbox.openembedded.net/packages/?qalog=1

In most cases, the problem is that recipes simply pass
- -L${STAGING_LIBDIR} as LDFLAGS instead of using the full ${LDFLAGS}
variable. The result is that flags such as --hash-style=gnu are
getting ignored.

What are your thoughts?

- --
Jeremy LAINE
Bolloré telecom | 11bis, rue Scribe | F-75009 Paris
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknaLysACgkQCL1n3lVB9EZgbQCgoQpUwdae7elUHWag8wqAROY7
D0sAmQGjH0zrO8OxgI5MPfSAshQz9Fuu
=to11
-----END PGP SIGNATURE-----


[-- Attachment #2: fatal_ldflags.patch --]
[-- Type: text/x-diff, Size: 450 bytes --]

diff --git a/classes/insane.bbclass b/classes/insane.bbclass
index 3e519c3..9fc5f07 100644
--- a/classes/insane.bbclass
+++ b/classes/insane.bbclass
@@ -184,7 +184,7 @@ def package_qa_make_fatal_error(error_class, name, path,d):
 
     TODO: Load a whitelist of known errors
     """
-    return not error_class in [0, 5, 7, 9]
+    return not error_class in [0, 5, 7]
 
 def package_qa_write_error(error_class, name, path, d):
     """

[-- Attachment #3: fatal_ldflags.patch.sig --]
[-- Type: application/octet-stream, Size: 72 bytes --]

             reply	other threads:[~2009-04-06 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 16:34 Jeremy Lainé [this message]
2009-04-06 17:58 ` [RFC] make "LDFLAGS ignored" QA errors fatal Koen Kooi
2009-04-06 21:49 ` Khem Raj
2009-04-07  7:01   ` Koen Kooi
2009-04-07  9:23   ` Phil Blundell
2009-04-07 15:41     ` Andrea Adami
2009-04-07 15:50       ` Phil Blundell
2009-04-08  8:50       ` Jeremy Lainé
2009-04-08  9:26         ` Andrea Adami
2009-04-14 19:16     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49DA2F2C.60008@bolloretelecom.eu \
    --to=jeremy.laine@bolloretelecom.eu \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox