From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [RFC] make "LDFLAGS ignored" QA errors fatal
Date: Mon, 06 Apr 2009 19:58:30 +0200 [thread overview]
Message-ID: <grdfs6$flp$1@ger.gmane.org> (raw)
In-Reply-To: <49DA2F2C.60008@bolloretelecom.eu>
On 06-04-09 18:34, Jeremy Lainé wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I have spent quite some time cleaning up a bunch of recipes which were
> triggering "LDFLAGS ignored" QA errors, and I don't really want to
> have to do this again in the future. I suggest we stop whitelisting
> this kind of QA error, using the attached patch.
>
> To track down the faulty packages I have made use of oestats output
> (note that not all QA errors are "LDFLAGS ignored"):
>
> http://tinderbox.openembedded.net/packages/?qalog=1
>
> In most cases, the problem is that recipes simply pass
> - -L${STAGING_LIBDIR} as LDFLAGS instead of using the full ${LDFLAGS}
> variable. The result is that flags such as --hash-style=gnu are
> getting ignored.
>
> What are your thoughts?
I think making them fatal is a good idea. I do have some recipes where I
can't fix LDFLAGS properly yet, but I can do INSANE_SKIP = 1 inside
those for the time being.
So: +1
regards,
Koen
next prev parent reply other threads:[~2009-04-06 18:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 16:34 [RFC] make "LDFLAGS ignored" QA errors fatal Jeremy Lainé
2009-04-06 17:58 ` Koen Kooi [this message]
2009-04-06 21:49 ` Khem Raj
2009-04-07 7:01 ` Koen Kooi
2009-04-07 9:23 ` Phil Blundell
2009-04-07 15:41 ` Andrea Adami
2009-04-07 15:50 ` Phil Blundell
2009-04-08 8:50 ` Jeremy Lainé
2009-04-08 9:26 ` Andrea Adami
2009-04-14 19:16 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='grdfs6$flp$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox