Number 1 tip for getting your patch committed

Number 1 tip for getting your patch committed

[Philip Balister]

Follow the commit log message policy at:

http://wiki.openembedded.net/index.php/Commit_log_example

and use git send-email to send the patch to the list. If you do this, it 
makes the act of retrieving the patch from patchwork trivial (see 
contrib/patchwprk/pw-am.sh).

This leaves you in a position where you can discuss the patch with 
someone with commit access and they can easily apply and push the patch.

Thanks,

Philip

Using `git send-email` (was: Number 1 tip for getting your patch committed)

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

[Sorry guys for spamming the list with my messages. But I want to get my
questions out to you so that I can scratch it from my list.]


Am Donnerstag, den 21.01.2010, 07:58 -0500 schrieb Philip Balister:
> Follow the commit log message policy at:
> 
> http://wiki.openembedded.net/index.php/Commit_log_example
> 
> and use git send-email to send the patch to the list. If you do this, it 
> makes the act of retrieving the patch from patchwork trivial (see 
> contrib/patchwprk/pw-am.sh).
> 
> This leaves you in a position where you can discuss the patch with 
> someone with commit access and they can easily apply and push the patch.

I have two problems with this.

Firstly using `git send-email` is nowhere mentioned in the commit policy
[1].

Secondly for a lot of people using `git send-email` is no option because
setup is too difficult, their MUA does not integrate well with `git
send-email` so the address book is not available, they do want to have
sent messages archived in their Sent folder, they want to ask some
questions regarding the patch and therefore need to write a message and
attach it.

In my opinion we should therefore find a way to also work easily with
attached patches having been created with `git format-patch`. Can some
of the developers mention what the disadvantage of attached patches is.
You can easily quote them to and saving and applying should be as easy
as with messages sent using `git send-email`.

The only disadvantage I can think of seems to be that it is not
displayed in the mailing list archive.

And of course that it is not easy to retrieve them from Patchwork. If
that is the only obstacle I would try to contact the Patchwork hackers
and ask them to implement an option to retrieve the attachment if it has
for example the extension »patch« or »diff«.


Thanks,

Paul


[1] http://wiki.openembedded.net/index.php/Commit_Policy

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: Using `git send-email` (was: Number 1 tip for getting your patch committed)

[Holger Hans Peter Freyther]

On Saturday 23 January 2010 23:06:22 Paul Menzel wrote:

> In my opinion we should therefore find a way to also work easily with
> attached patches having been created with `git format-patch`. Can some
> of the developers mention what the disadvantage of attached patches is.
> You can easily quote them to and saving and applying should be as easy
> as with messages sent using `git send-email`.

E.g. I'm still using git format-patch but most of the time as inline message, 
with KMail there is an option to not wordwrap so the patch will not be 
altered. I hope/asume that these options exist for other mailers too?



> And of course that it is not easy to retrieve them from Patchwork. If
> that is the only obstacle I would try to contact the Patchwork hackers
> and ask them to implement an option to retrieve the attachment if it has
> for example the extension »patch« or »diff«.

First test if it already works and then pester them?

Re: Using `git send-email` (was: Number 1 tip for getting your patch committed)

[Khem Raj]

On Sat, Jan 23, 2010 at 2:06 PM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> [Sorry guys for spamming the list with my messages. But I want to get my
> questions out to you so that I can scratch it from my list.]
>
>
> Am Donnerstag, den 21.01.2010, 07:58 -0500 schrieb Philip Balister:
>> Follow the commit log message policy at:
>>
>> http://wiki.openembedded.net/index.php/Commit_log_example
>>
>> and use git send-email to send the patch to the list. If you do this, it
>> makes the act of retrieving the patch from patchwork trivial (see
>> contrib/patchwprk/pw-am.sh).
>>
>> This leaves you in a position where you can discuss the patch with
>> someone with commit access and they can easily apply and push the patch.
>
> I have two problems with this.
>
> Firstly using `git send-email` is nowhere mentioned in the commit policy
> [1].
>
> Secondly for a lot of people using `git send-email` is no option because
> setup is too difficult, their MUA does not integrate well with `git
> send-email` so the address book is not available, they do want to have
> sent messages archived in their Sent folder, they want to ask some
> questions regarding the patch and therefore need to write a message and
> attach it.

all can be achieved with git send-email you need to add
[sendemail]
        to = openembedded-devel@lists.openembedded.org

to openembedded/.git/config and you dont have to type in to
address everytime you send patch and if you have proper Sign-offs then
it CC the mail to people in Signed-off-by too.

but I do agree some people might want to use other mail clients
I would say than to follow the guidelines mentioned in linux kernel
project for various email clients Documentation/
email-clients.txt


>
> In my opinion we should therefore find a way to also work easily with
> attached patches having been created with `git format-patch`. Can some
> of the developers mention what the disadvantage of attached patches is.
> You can easily quote them to and saving and applying should be as easy
> as with messages sent using `git send-email`.
>
> The only disadvantage I can think of seems to be that it is not
> displayed in the mailing list archive.
>
> And of course that it is not easy to retrieve them from Patchwork. If
> that is the only obstacle I would try to contact the Patchwork hackers
> and ask them to implement an option to retrieve the attachment if it has
> for example the extension »patch« or »diff«.
>
>
> Thanks,
>
> Paul
>
>
> [1] http://wiki.openembedded.net/index.php/Commit_Policy
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>

Re: Using `git send-email` (was: Number 1 tip for getting your patch committed)

[Mark Brown]

On Sat, Jan 23, 2010 at 11:06:22PM +0100, Paul Menzel wrote:

> Secondly for a lot of people using `git send-email` is no option because
> setup is too difficult, their MUA does not integrate well with `git
> send-email` so the address book is not available, they do want to have
> sent messages archived in their Sent folder, they want to ask some
> questions regarding the patch and therefore need to write a message and
> attach it.

There's also other variants like git imap-send.  The send-email
suggestion could be rewritten as "do something which git am understands
out of the box", it's approximately equivalent.

> In my opinion we should therefore find a way to also work easily with
> attached patches having been created with `git format-patch`. Can some
> of the developers mention what the disadvantage of attached patches is.
> You can easily quote them to and saving and applying should be as easy
> as with messages sent using `git send-email`.

> The only disadvantage I can think of seems to be that it is not
> displayed in the mailing list archive.

Attaching patches also upsets most tools, they tend to assume that the
body of the mail is supposed to be part of the commit message (which it
would normally be) which tends not to look too pretty.  Replying can be
an issue with some MUAs too, especially if the attachment gets reencoded
due to not being seven bit clean.