Patches and patchwork

Patches and patchwork

[Douglas Royds]

I have submitted a patch, and after discussion want to correct it.

Do I submit the corrected patch as a reply to the existing email thread, 
or start a new thread? If I submit the new patch as a reply to the 
existing thread, will patchwork pick up the corrected patch, or remain 
on the original one?

Thanks,
Douglas.





=======================================================================
This email, including any attachments, is only for the intended
addressee.  It is subject to copyright, is confidential and may be
the subject of legal or other privilege, none of which is waived or
lost by reason of this transmission.
If the receiver is not the intended addressee, please accept our
apologies, notify us by return, delete all copies and perform no
other act on the email.
Unfortunately, we cannot warrant that the email has not been
 altered or corrupted during transmission.
=======================================================================

Re: Patches and patchwork

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1721 bytes --]

Am Freitag, den 19.03.2010, 12:47 +1300 schrieb Douglas Royds:
> I have submitted a patch, and after discussion want to correct it.
> 
> Do I submit the corrected patch as a reply to the existing email thread, 
> or start a new thread?

In my opinion, if it is just a single patch and not a patch series a
reply to the original message should sent.

The new patch should be marked with »v2«. (Look for `--subject-prefix`
`git help format-patch`.)

> If I submit the new patch as a reply to the 
> existing thread, will patchwork pick up the corrected patch, or remain 
> on the original one?

Patchwork will create a new item for this patch. Look at the IDs 1732
and 1734 for my patches. (Although in this case the first version was
the correct one.)

You can update the state to superseded of the original patch using the
Web interface or `pwclient` [1].

> =======================================================================
> This email, including any attachments, is only for the intended
> addressee.  It is subject to copyright, is confidential and may be
> the subject of legal or other privilege, none of which is waived or
> lost by reason of this transmission.
> If the receiver is not the intended addressee, please accept our
> apologies, notify us by return, delete all copies and perform no
> other act on the email.
> Unfortunately, we cannot warrant that the email has not been
>  altered or corrupted during transmission.
> =======================================================================

Please do not sent messages with such disclaimers to public lists if you
can.


Thanks,

Paul


[1] http://patchwork.openembedded.org/project/openembedded/

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]