Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: k.kooi@student.utwente.nl
Cc: openembedded-devel@lists.openembedded.org
Subject: [RFC][PATCH] module-base.bbclass: keep PR if MACHINE_KERNEL_PR is not set
Date: Fri, 14 May 2010 17:10:51 +0200	[thread overview]
Message-ID: <4BED67FB.1060900@eukrea.com> (raw)
In-Reply-To: <1272921691-6963-1-git-send-email-eric@eukrea.com>

Hi Koen,

I was told you are the person to contact about MACHINE_KERNEL_PR so may 
you please have a look to the patch below - also available here : 
http://patchwork.openembedded.org/patch/2012/

Actually, when compiling modules (out of tree), we loose PR if 
MACHINE_KERNEL_PR is not set.

Is this patch fine to solve this problem or is there another prefered way ?

The same problem was already solved in kernel.bbclass by the following 
comit
http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=35e7b34d3b5b96ed11bc7ed6b2a5d08e6183d8a3

Thanks,
Eric

Signed-off-by: Eric Benard<eric@eukrea.com>
---
   classes/module-base.bbclass |    7 ++++++-
   1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/classes/module-base.bbclass b/classes/module-base.bbclass
index bc53e1b..9aaaa4e 100644
--- a/classes/module-base.bbclass
+++ b/classes/module-base.bbclass
@@ -7,7 +7,12 @@ export CROSS_COMPILE = "${TARGET_PREFIX}"

   # A machine.conf or local.conf can increase MACHINE_KERNEL_PR to force
   # rebuilds for kernel and external modules
-PR = "${MACHINE_KERNEL_PR}"
+python __anonymous () {
+    machine_kernel_pr = bb.data.getVar('MACHINE_KERNEL_PR', d, True)
+
+    if machine_kernel_pr:
+       bb.data.setVar('PR', machine_kernel_pr, d)
+}

   export KERNEL_VERSION = 
"${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}"
   export KERNEL_SOURCE = 
"${@base_read_file('${STAGING_KERNEL_DIR}/kernel-source')}"



  parent reply	other threads:[~2010-05-14 15:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-03 21:21 [PATCH] module-base.bbclass: keep PR if MACHINE_KERNEL_PR is not set Eric Benard
2010-05-12 15:34 ` Eric Bénard
2010-05-14 15:10 ` Eric Bénard [this message]
2010-05-14 15:52   ` [RFC][PATCH] " Koen Kooi
2010-05-14 17:17     ` Eric Bénard
2010-05-14 17:34       ` Koen Kooi
2010-05-14 17:45         ` Eric Bénard
2010-05-14 19:55           ` Phil Blundell
2010-05-14 20:15             ` Eric Bénard
2010-05-14 21:02               ` Phil Blundell
2010-05-17  7:12                 ` Eric Bénard
2010-05-17  8:02                   ` Phil Blundell
2010-05-14 16:25   ` Phil Blundell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BED67FB.1060900@eukrea.com \
    --to=eric@eukrea.com \
    --cc=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox