psplash vs. psplash-$DISTRO

psplash vs. psplash-$DISTRO

[Andrea Adami]

Hello,

building console-image for minimal distro I receive the following warning:

IMHO we have an issue with psplash-zap:
RRECOMMENDS_${PN} = "psplash-angstrom"
should probably be
RRECOMMENDS_${PN} = "${SPLASH}"

But here we have a new issue: not all distro are defining $SPLASH, in
particular look at the images using ZZSPLASH:
( from  http://fr.pastebin.ca/1876829 )

./console-base-image.bb:ZZAPSPLASH = '
${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'
./gnuradio-image.bb:ZZAPSPLASH = '
${@base_contains("MACHINE_FEATURES", "screen", "psplash-zap", "",d)}'

Now, for a distro using that images *does not* define $SPLASH, what happens is:

./image.bbclass:# set sane default for the SPLASH variable
./image.bbclass:SPLASH ?= ""

At first I thought to fix psplash-zap_1.0.bb but this would break some
distro/image combination...
In theory all distro should support all kind of images, with and
without splashscreen...

Confused

Andrea

Re: psplash vs. psplash-$DISTRO

[Andrea Adami]

FWIW here is the missing warning:

On Thu, Jun 3, 2010 at 11:54 PM, Andrea Adami <andrea.adami@gmail.com> wrote:
> Hello,
>
> building console-image for minimal distro I receive the following warning:
>

ERROR: Multiple .bb files are due to be built which each provide
virtual/psplash (/oe/openembedded/recipes/psplash/psplash_svn.bb
/oe/openembedded/recipes/psplash/psplash-angstrom_svn.bb).

Sorry...

Andrea

Re: psplash vs. psplash-$DISTRO

[Tom Rini]

Andrea Adami wrote:
> Hello,
> 
> building console-image for minimal distro I receive the following warning:
> 
> IMHO we have an issue with psplash-zap:
> RRECOMMENDS_${PN} = "psplash-angstrom"
> should probably be
> RRECOMMENDS_${PN} = "${SPLASH}"

Yes, that's right.  Or...

> But here we have a new issue: not all distro are defining $SPLASH, in
> particular look at the images using ZZSPLASH:
> ( from  http://fr.pastebin.ca/1876829 )

I guess, why is it a problem and isn't there something setting a default 
now?  I swear I saw that the other day.  But if they don't have SPLASH 
they probably don't want psplash-zap.

-- 
Tom Rini
Mentor Graphics Corporation

Re: psplash vs. psplash-$DISTRO

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03-06-10 23:54, Andrea Adami wrote:
> Hello,
> 
> building console-image for minimal distro I receive the following warning:
> 
> IMHO we have an issue with psplash-zap:
> RRECOMMENDS_${PN} = "psplash-angstrom"
> should probably be
> RRECOMMENDS_${PN} = "${SPLASH}"

No, SPLASH is an image var and has no place in RRECOMMENDS*.
Furthermore, every image that is using psplash-zap was created by an
angstrom developer, so what is the actual problem you are trying to address?

In the future if you want to go break basic stuff, please RFC a patch on
this mailinglist first.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMEpZ1MkyGM64RGpERAh3kAJ0Vp6VVb4IllUpzOnrcGTgHZNokmwCfQBql
v4yWQ0e8PaISWE+8CfXQ/88=
=eq4h
-----END PGP SIGNATURE-----

Re: psplash vs. psplash-$DISTRO

[Andrea Adami]

hello koen,

> No, SPLASH is an image var and has no place in RRECOMMENDS*.

My bad.
Until today I thought SPLASH was a distro thing...:/

> Furthermore, every image that is using psplash-zap was created by an
> angstrom developer, so what is the actual problem you are trying to address?

I was trying minimal and got:

ERROR: Multiple .bb files are due to be built which each provide
virtual/psplash (/oe/openembedded/recipes/psplash/psplash_svn.bb
/oe/openembedded/recipes/psplash/psplash-angstrom_svn.bb).

> In the future if you want to go break basic stuff, please RFC a patch on
> this mailinglist first.

Well, this is not so basic: only 2 images are using psplash-zap!
But you're right, an RFC would have been more appropriated than this thread.

Regards

Andrea