Re: [PATCH] Add a waf bitbake class. (Koen Kooi)

Re: [PATCH] Add a waf bitbake class. (Koen Kooi)

[Sean_Hudson]

On 18-06-10 21:58, Koen Kooi <k.kooi@student.utwente.nl> wrote:
------------------------------
> On 18-06-10 21:58, Sean_Hudson@Dell.com wrote:
> > Hi All,
> > 
> >   We are using waf for some of our modules and decided to add a class to make it easier to write recipes.
>
> Why is there still a staging method in there? Those have been deprecated
> for months now.

Thanks for taking the time to reply.  To answer your question, the waf class was cloned from the autotools.bbclass, so the staging stuff came from there.  Is there a better way to handle the staging?

It's a fairly trivial class, but I'm interested to hear if anyone had any additional thoughts on ways to improve the class?

Re: [PATCH] Add a waf bitbake class. (Koen Kooi)

[Tom Rini]

Sean_Hudson@Dell.com wrote:
> On 18-06-10 21:58, Koen Kooi <k.kooi@student.utwente.nl> wrote:
> ------------------------------
>> On 18-06-10 21:58, Sean_Hudson@Dell.com wrote:
>>> Hi All,
>>>
>>>   We are using waf for some of our modules and decided to add a class to make it easier to write recipes.
>> Why is there still a staging method in there? Those have been deprecated
>> for months now.
> 
> Thanks for taking the time to reply.  To answer your question, the waf class was cloned from the autotools.bbclass, so the staging stuff came from there.  Is there a better way to handle the staging?
> 
> It's a fairly trivial class, but I'm interested to hear if anyone had any additional thoughts on ways to improve the class?

Koen's point is that for a long time now do_stage has been set as legacy 
and 'do_install' should instead set things up such that a package can 
then be installed into the sysroots/ directory and reused.  Like 
autotools.bbclass does today :)

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] Add a waf bitbake class. (Koen Kooi)

[Tom Rini]

Tom Rini wrote:
> Sean_Hudson@Dell.com wrote:
>> On 18-06-10 21:58, Koen Kooi <k.kooi@student.utwente.nl> wrote:
>> ------------------------------
>>> On 18-06-10 21:58, Sean_Hudson@Dell.com wrote:
>>>> Hi All,
>>>>
>>>>   We are using waf for some of our modules and decided to add a 
>>>> class to make it easier to write recipes.
>>> Why is there still a staging method in there? Those have been deprecated
>>> for months now.
>>
>> Thanks for taking the time to reply.  To answer your question, the waf 
>> class was cloned from the autotools.bbclass, so the staging stuff came 
>> from there.  Is there a better way to handle the staging?
>>
>> It's a fairly trivial class, but I'm interested to hear if anyone had 
>> any additional thoughts on ways to improve the class?
> 
> Koen's point is that for a long time now do_stage has been set as legacy 
> and 'do_install' should instead set things up such that a package can 
> then be installed into the sysroots/ directory and reused.  Like 
> autotools.bbclass does today :)

And to be more clear, see is_legacy_staging in staging.bbclass

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] Add a waf bitbake class. (Koen Kooi)

[Sean_Hudson]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

> Tom Rini wrote:
> > Sean_Hudson at Dell.com wrote:
> >> On 18-06-10 21:58, Koen Kooi <k.kooi at student.utwente.nl> wrote:
> >> ------------------------------
> >>> On 18-06-10 21:58, Sean_Hudson at Dell.com wrote:
> >>>> Hi All,
> >>>>
> >>>>   We are using waf for some of our modules and decided to add a
> >>>> class to make it easier to write recipes.
> >>> Why is there still a staging method in there? Those have been deprecated
> >>> for months now.
> >>
> >> Thanks for taking the time to reply.  To answer your question, the waf
> >> class was cloned from the autotools.bbclass, so the staging stuff came
> >> from there.  Is there a better way to handle the staging?
> >>
> >> It's a fairly trivial class, but I'm interested to hear if anyone had
> >> any additional thoughts on ways to improve the class?
> >
> > Koen's point is that for a long time now do_stage has been set as legacy
> > and 'do_install' should instead set things up such that a package can
> > then be installed into the sysroots/ directory and reused.  Like
> > autotools.bbclass does today :)
>
> And to be more clear, see is_legacy_staging in staging.bbclass

Thanks for clearing that up.  I've attached an updated version that drops the staging function.

[-- Attachment #2: waf.bbclass --]
[-- Type: application/octet-stream, Size: 516 bytes --]

# WAF project class.

DEPENDS += python

# Conditionally set the verbose option.
# WAF_VERBOSE="-v"

waf_do_compile() {
	./waf ${WAF_VERBOSE} build 
}

waf_do_clean() {
	./waf ${WAF_VERBOSE} clean
}

waf_do_configure() {
	if [ -x ${S}/waf ]; then
		${S}/waf ${WAF_VERBOSE} configure --prefix=${prefix} ${EXTRA_OECONF} "$@"
	else
		oefatal "executable waf script not found"
	fi
}

waf_do_install() {
	./waf ${WAF_VERBOSE} install --destdir="${D}" "$@"
}

EXPORT_FUNCTIONS do_compile do_clean do_configure do_install 

Re: [PATCH] Add a waf bitbake class. (Koen Kooi)

[AJ ONeal]

Thanks for your help, I got it working.

http://blog.coolaj86.info/2010/07/26/WAF-on-OpenEmbedded

AJ ONeal

On Tue, Jul 27, 2010 at 10:44 AM, <Sean_Hudson@dell.com> wrote:

>  AJ,
>
>
>
>   Yes, by design, WAF is generally include with the source code.  (see
> this link<http://freehackers.org/~tnagy/wafbook/index.html#_installing_waf_on_a_system>for reference) There is no specification to WAF to cross compile, rather, it
> will pick up the environment from the OE shell and act accordingly.  One
> additional thought, in order to get the example binary into the package
> correctly, don’t forget to add a FILES_${PN} directive to your OE recipe.
>
>
>
>   Hope this helps!
>
>
>
>     -Sean
>
>
>
> *From:* AJ ONeal [mailto:coolaj86@gmail.com]
> *Sent:* Monday, July 26, 2010 11:12 PM
>
> *To:* Hudson, Sean
> *Subject:* Re: [oe] [PATCH] Add a waf bitbake class. (Koen Kooi)
>
>
>
> I'm trying to get a Hello World example together using bitbake and WAF
>
>
>
> http://blog.coolaj86.info/2010/07/26/WAF-on-OpenEmbedded
>
>
>
> Will you please help me complete this?
>
>
>
> Is WAF supposed to be packaged with the source code?
>
> How do we specify that WAF should cross compile rather than regular
> compile?
>
>
>
> Thanks,
>
>
>
> AJ ONeal
>
> On Thu, Jul 8, 2010 at 1:15 PM, <Sean_Hudson@dell.com> wrote:
>
> It's quite simple.  In the recipe, inherit from the waf class, and you're
> good to go.  One caveat, I didn't see this pulled into OE by one of the
> committers, so be aware that it is not available other than through the
> mailing list...
>
> Sample recipe using the waf class...
>        DESCRIPTION = "foo"
>        LICENSE = "GPL"
>        SRC_URI = ""
>        S = "${WORKDIR}/trunk"
>
>        inherit waf
>
> From: AJ ONeal [mailto:coolaj86@gmail.com]
> Sent: Thursday, July 08, 2010 12:42 AM
> To: Hudson, Sean
> Subject: Re: [oe] [PATCH] Add a waf bitbake class. (Koen Kooi)
>
>
> How would I use this patch with something like Node.js, which using waf for
> compiling?
>
> Do you have any sample .bb files that show how this is done? Or any
> documentation?
>
> AJ ONeal
>
>
>