[PATCH] ecore: remove fix-ecore-fb-initialization.patch

[PATCH] ecore: remove fix-ecore-fb-initialization.patch

[Simon Busch]

Removing the fix-ecore-fb-initialization patch as it let ecore open the supplied
touchscreen device twice which results in an error on platforms where the touchscreen
device node can be opened only once. Furthermore I doubt that it is necessary to open the
touchscreen device node more than one time.

Signed-off-by: Simon Busch <morphis@gravedo.de>
---
 recipes/efl1/ecore.inc                             |    2 -
 .../efl1/ecore/fix-ecore-fb-initialization.patch   |   29 --------------------
 2 files changed, 0 insertions(+), 31 deletions(-)
 delete mode 100644 recipes/efl1/ecore/fix-ecore-fb-initialization.patch

diff --git a/recipes/efl1/ecore.inc b/recipes/efl1/ecore.inc
index bb7eea5..081572d 100644
--- a/recipes/efl1/ecore.inc
+++ b/recipes/efl1/ecore.inc
@@ -12,8 +12,6 @@ inherit efl
 
 BBCLASSEXTEND = "native"
 
-SRC_URI += "file://fix-ecore-fb-initialization.patch"
-
 do_configure_prepend() {
 	touch ${S}/po/Makefile.in.in || true
 	sed -i -e 's: po::g' ${S}/Makefile.am
diff --git a/recipes/efl1/ecore/fix-ecore-fb-initialization.patch b/recipes/efl1/ecore/fix-ecore-fb-initialization.patch
deleted file mode 100644
index 2ac61ca..0000000
--- a/recipes/efl1/ecore/fix-ecore-fb-initialization.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-#
-# The whole ecore-fb init logic is somewhat flawed; with this patch we
-# get at least a working touchscreen w/ tslib again.
-#
-# Signed-off-by: Michael 'Mickey' Lauer <mlauer@vanille-media.de>
-#
-
-Index: ecore/src/lib/ecore_fb/ecore_fb.c
-===================================================================
---- ecore.orig/src/lib/ecore_fb/ecore_fb.c
-+++ ecore/src/lib/ecore_fb/ecore_fb.c
-@@ -46,6 +46,9 @@
- 
-    if (!ecore_fb_vt_init())
-      return --_ecore_fb_init_count;
-+     
-+   if (!ecore_fb_ts_init())
-+     return --_ecore_fb_init_count;
- 
-    ECORE_FB_EVENT_KEY_DOWN          = ecore_event_type_new();
-    ECORE_FB_EVENT_KEY_UP            = ecore_event_type_new();
-@@ -70,6 +73,7 @@
-    if (--_ecore_fb_init_count != 0)
-      return _ecore_fb_init_count;
- 
-+   ecore_fb_ts_shutdown();
-    ecore_fb_vt_shutdown();
- 
-    return _ecore_fb_init_count;
-- 
1.7.0.4

Re: [PATCH] ecore: remove fix-ecore-fb-initialization.patch

[Stefan Schmidt]

Hello.

On Tue, 2010-08-10 at 21:29, Simon Busch wrote:
> Removing the fix-ecore-fb-initialization patch as it let ecore open the supplied
> touchscreen device twice which results in an error on platforms where the touchscreen
> device node can be opened only once. Furthermore I doubt that it is necessary to open the
> touchscreen device node more than one time.

Sounds good, but I want to hear Mickey on this before pushing it as it is his
patch.

regards
Stefan Schmidt

Re: [PATCH] ecore: remove fix-ecore-fb-initialization.patch

[Martin Jansa]

On Fri, Aug 13, 2010 at 11:52:26PM +0200, Stefan Schmidt wrote:
> Hello.
> 
> On Tue, 2010-08-10 at 21:29, Simon Busch wrote:
> > Removing the fix-ecore-fb-initialization patch as it let ecore open the supplied
> > touchscreen device twice which results in an error on platforms where the touchscreen
> > device node can be opened only once. Furthermore I doubt that it is necessary to open the
> > touchscreen device node more than one time.
> 
> Sounds good, but I want to hear Mickey on this before pushing it as it is his
> patch.

Tested on EFL bump I have in my queue and doesn't break anything on
om-gta02, so look OK.

Acked-by: Martin Jansa <Martin.Jansa@gmail.com>

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Re: [PATCH] ecore: remove fix-ecore-fb-initialization.patch

[Michael 'Mickey' Lauer]

Am Freitag, den 13.08.2010, 23:52 +0200 schrieb Stefan Schmidt:
> Hello.
> 
> On Tue, 2010-08-10 at 21:29, Simon Busch wrote:
> > Removing the fix-ecore-fb-initialization patch as it let ecore open the supplied
> > touchscreen device twice which results in an error on platforms where the touchscreen
> > device node can be opened only once. Furthermore I doubt that it is necessary to open the
> > touchscreen device node more than one time.
> 
> Sounds good, but I want to hear Mickey on this before pushing it as it is his
> patch.

NACK. Last time I checked, this patch was still necessary to fix
touchscreen access using Ecore on pure framebuffer. There may be
better approaches to it, but removing it now will break ecore on fb.

Regards,
-- 
:M:

Re: [PATCH] ecore: remove fix-ecore-fb-initialization.patch

[Simon Busch]

Am 14.08.2010 21:26, schrieb Michael 'Mickey' Lauer:
> Am Freitag, den 13.08.2010, 23:52 +0200 schrieb Stefan Schmidt:
>> Hello.
>>
>> On Tue, 2010-08-10 at 21:29, Simon Busch wrote:
>>> Removing the fix-ecore-fb-initialization patch as it let ecore open the supplied
>>> touchscreen device twice which results in an error on platforms where the touchscreen
>>> device node can be opened only once. Furthermore I doubt that it is necessary to open the
>>> touchscreen device node more than one time.
>>
>> Sounds good, but I want to hear Mickey on this before pushing it as it is his
>> patch.
> 
> NACK. Last time I checked, this patch was still necessary to fix
> touchscreen access using Ecore on pure framebuffer. There may be
> better approaches to it, but removing it now will break ecore on fb.

For me ecore worked on plain fb without this patch. Touchscreen access
was possible and elementary-test worked fine. If it's not the case on
other devies than the palm pre we have to find a way around this as it
will break usage of ecore_fb for the palm pre!

Will take a look into the code of ecore_fb if there is another way.

regards,
morphis

Re: [PATCH] ecore: remove fix-ecore-fb-initialization.patch

[Simon Busch]

Am 14.08.2010 21:26, schrieb Michael 'Mickey' Lauer:
> Am Freitag, den 13.08.2010, 23:52 +0200 schrieb Stefan Schmidt:
>> Hello.
>>
>> On Tue, 2010-08-10 at 21:29, Simon Busch wrote:
>>> Removing the fix-ecore-fb-initialization patch as it let ecore open the supplied
>>> touchscreen device twice which results in an error on platforms where the touchscreen
>>> device node can be opened only once. Furthermore I doubt that it is necessary to open the
>>> touchscreen device node more than one time.
>>
>> Sounds good, but I want to hear Mickey on this before pushing it as it is his
>> patch.
> 
> NACK. Last time I checked, this patch was still necessary to fix
> touchscreen access using Ecore on pure framebuffer. There may be
> better approaches to it, but removing it now will break ecore on fb.
> 
> Regards,

I think the best solution to work around this is using tsmd: our
touchscreen daemon which opens the touchscreen device node and forwards
it to a uninput device which can be opened more than on time.

Will write a recipe for it and send it in for integration.

regards,
morphis