Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Tom Rini <tom_rini@mentor.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] lib_package.bbclass: fix packaging of static libs, inherit binconfig
Date: Sat, 13 Nov 2010 12:12:40 -0700	[thread overview]
Message-ID: <4CDEE328.6060307@mentor.com> (raw)
In-Reply-To: <4CDEBCC5.7050401@opendreambox.org>

On 11/13/2010 09:28 AM, Andreas Oberritter wrote:
> Ping
>
> On 10/25/2010 04:20 PM, Andreas Oberritter wrote:
>> * Package ${libdir}/*.a and /lib/*.a into ${PN}-static instead of ${PN}-dev

Where is the FILES_${PN}-static line below?

>> * Although it packaged ${bindir}/*-config into FILES_${PN}-dev, it did
>>    not include the required mangling applied by binconfig.bbclass.

Not sure here.  Not all lib packages need binconfig mangling so it's up 
to the recipe to say "I need this", usually at least.

>>
>> Signed-off-by: Andreas Oberritter<obi@opendreambox.org>
>> ---
>>   classes/lib_package.bbclass |   17 +++++++++--------
>>   1 files changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/classes/lib_package.bbclass b/classes/lib_package.bbclass
>> index 82c9370..7e72dc8 100644
>> --- a/classes/lib_package.bbclass
>> +++ b/classes/lib_package.bbclass
>> @@ -1,10 +1,11 @@
>> +inherit binconfig
>> +
>>   PACKAGES += "${PN}-bin"
>>
>> -FILES_${PN} = "${libexecdir} ${libdir}/lib*${SOLIBS} \
>> -	    ${sysconfdir} ${sharedstatedir} ${localstatedir} \
>> -	    ${base_libdir}/*${SOLIBS} \
>> -	    ${datadir}/${PN} ${libdir}/${PN}"
>> -FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la \
>> -		${libdir}/*.a ${libdir}/pkgconfig /lib/*.a /lib/*.o \
>> -		${datadir}/aclocal ${bindir}/*-config"
>> -FILES_${PN}-bin = "${bindir}/* ${sbindir}/* /bin/* /sbin/*"
>> +FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
>> +            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
>> +            ${base_libdir}/*${SOLIBS} \
>> +            ${datadir}/${PN} ${libdir}/${PN}/*"
>> +
>> +FILES_${PN}-bin = "${bindir}/* ${sbindir}/* \
>> +                ${base_bindir}/* ${base_sbindir}/*"
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>


-- 
Tom Rini
Mentor Graphics Corporation



  reply	other threads:[~2010-11-13 19:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-17 22:15 [PATCH] libfribidi-0.10.4: update recipe, fix packaging Andreas Oberritter
2010-10-18  7:22 ` Koen Kooi
2010-10-18 10:21   ` Andreas Oberritter
2010-10-18 10:48     ` Koen Kooi
2010-10-18 11:41       ` Andreas Oberritter
2010-10-19 18:01         ` [RFC] update lib_package.bbclass Andreas Oberritter
2010-10-20  7:47           ` Koen Kooi
2010-10-20 10:50             ` Andreas Oberritter
2010-10-25 14:20               ` [PATCH] lib_package.bbclass: fix packaging of static libs, inherit binconfig Andreas Oberritter
2010-11-13 16:28                 ` Andreas Oberritter
2010-11-13 19:12                   ` Tom Rini [this message]
2010-11-14 23:49                     ` Andreas Oberritter
2010-11-15 15:07                       ` Tom Rini
2010-11-15 15:46                         ` Andreas Oberritter
2010-11-15 18:11                           ` Tom Rini
2010-11-16 11:52                             ` Andreas Oberritter
2010-11-16 16:51 ` [PATCH] libfribidi-0.10.4: update recipe, fix packaging Andreas Oberritter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CDEE328.6060307@mentor.com \
    --to=tom_rini@mentor.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox