Re: [PATCH] lib_package.bbclass: fix packaging of static libs, inherit binconfig

[Andreas Oberritter <obi@opendreambox.org>]

On 11/13/2010 08:12 PM, Tom Rini wrote:
> On 11/13/2010 09:28 AM, Andreas Oberritter wrote:
>> Ping
>>
>> On 10/25/2010 04:20 PM, Andreas Oberritter wrote:
>>> * Package ${libdir}/*.a and /lib/*.a into ${PN}-static instead of
>>> ${PN}-dev
> 
> Where is the FILES_${PN}-static line below?

The default value from bitbake.conf is used.

>>> * Although it packaged ${bindir}/*-config into FILES_${PN}-dev, it did
>>>    not include the required mangling applied by binconfig.bbclass.
> 
> Not sure here.  Not all lib packages need binconfig mangling so it's up
> to the recipe to say "I need this", usually at least.

OK, Koen's proposal included "inherit binconfig", too, so I left it in.
I'll send an updated patch without it.

>>> Signed-off-by: Andreas Oberritter<obi@opendreambox.org>
>>> ---
>>>   classes/lib_package.bbclass |   17 +++++++++--------
>>>   1 files changed, 9 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/classes/lib_package.bbclass b/classes/lib_package.bbclass
>>> index 82c9370..7e72dc8 100644
>>> --- a/classes/lib_package.bbclass
>>> +++ b/classes/lib_package.bbclass
>>> @@ -1,10 +1,11 @@
>>> +inherit binconfig
>>> +
>>>   PACKAGES += "${PN}-bin"
>>>
>>> -FILES_${PN} = "${libexecdir} ${libdir}/lib*${SOLIBS} \
>>> -        ${sysconfdir} ${sharedstatedir} ${localstatedir} \
>>> -        ${base_libdir}/*${SOLIBS} \
>>> -        ${datadir}/${PN} ${libdir}/${PN}"
>>> -FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV}
>>> ${libdir}/*.la \
>>> -        ${libdir}/*.a ${libdir}/pkgconfig /lib/*.a /lib/*.o \
>>> -        ${datadir}/aclocal ${bindir}/*-config"
>>> -FILES_${PN}-bin = "${bindir}/* ${sbindir}/* /bin/* /sbin/*"
>>> +FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
>>> +            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
>>> +            ${base_libdir}/*${SOLIBS} \
>>> +            ${datadir}/${PN} ${libdir}/${PN}/*"
>>> +
>>> +FILES_${PN}-bin = "${bindir}/* ${sbindir}/* \
>>> +                ${base_bindir}/* ${base_sbindir}/*"
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
> 
>