Re: [PATCH] task-base: conditional wifi and bluetooth tasks in PACKAGES

[Douglas Royds <douglas.royds@taitradio.com>]

On 09/02/11 07:23, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 08-02-11 18:29, Tom Rini wrote:
>> On 02/07/2011 03:13 PM, Filip Zyzniewski wrote:
>>> This reduces amount of tasks for bootstrap-image from around 3400 to
>>> around 1600 for jlime.
>>>
>>> Signed-off-by: Filip Zyzniewski<filip.zyzniewski@gmail.com>
>> Can some of the other distro folks chime in here?
> Yeah, this patch is wrong, since task-base is supposed to drag in bt and
> wifi when it's available which includes usb, pci, serial, etc.

I believe Filip's patch is correct, in removing them from the PACKAGES 
list when these features are not set.

task-base already checks the MACHINE_FEATURES and DISTRO_FEATURES for 
bluetooth and wifi:

    RDEPENDS_task-base = "\
         ...
         ${@base_contains('COMBINED_FEATURES', 'bluetooth',
    'task-base-bluetooth', '',d)} \
         ${@base_contains('COMBINED_FEATURES', 'wifi', 'task-base-wifi',
    '',d)} \
         ...

The dependency on usb, pci, etc. is implemented in a python __anonymous 
function lower down in the file.


>>> ---
>>>    recipes/tasks/task-base.bb |    6 +++---
>>>    1 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/recipes/tasks/task-base.bb b/recipes/tasks/task-base.bb
>>> index 32d871d..c8d6df7 100644
>>> --- a/recipes/tasks/task-base.bb
>>> +++ b/recipes/tasks/task-base.bb
>>> @@ -1,5 +1,5 @@
>>>    DESCRIPTION = "Merge machine and distro options to create a basic
>>> machine task/package"
>>> -PR = "r92"
>>> +PR = "r93"
>>>
>>>    inherit task
>>>
>>> @@ -31,8 +31,8 @@ PACKAGES = ' \
>>>                ${@base_contains("MACHINE_FEATURES", "redboot",
>>> "task-base-redboot", "",d)} \
>>>                ${@base_contains("MACHINE_FEATURES", "apex",
>>> "task-base-apex", "",d)} \
>>>                \
>>> -            task-base-bluetooth \
>>> -            task-base-wifi \
>>> +            ${@base_contains("MACHINE_FEATURES", "bluetooth",
>>> "task-base-bluetooth", "",d)} \
>>> +            ${@base_contains("MACHINE_FEATURES", "wifi",
>>> "task-base-wifi", "",d)} \
>>>                \
>>>                ${@base_contains("DISTRO_FEATURES", "cramfs",
>>> "task-base-cramfs", "", d)} \
>>>                ${@base_contains("DISTRO_FEATURES", "ipsec",
>>> "task-base-ipsec", "", d)} \
>>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFNUYoQMkyGM64RGpERAuFAAJ9Y5jiml8NdBJpg5XmD7b8BlwjjFQCfXL8H
> xuKrNII4OscMLUu/S2dAejQ=
> =j2V5
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

=======================================================================
This email, including any attachments, is only for the intended
addressee.  It is subject to copyright, is confidential and may be
the subject of legal or other privilege, none of which is waived or
lost by reason of this transmission.
If the receiver is not the intended addressee, please accept our
apologies, notify us by return, delete all copies and perform no
other act on the email.
Unfortunately, we cannot warrant that the email has not been
altered or corrupted during transmission.
=======================================================================