[PATCH] udev/{acl, attr}: Fix install. Wanted to install to host /usr/bin/.

[PATCH] udev/{acl, attr}: Fix install. Wanted to install to host /usr/bin/.

[Leon Woestenberg]

The subdirectory Makefile includes a file, that overrides the
variables inherited from the parent Makefile. Those where provided
to the parent make through '-e'.

Make sure the subdir makes also use '-e'.

(An alternative fix is to sed the include file.)

Signed-off-by: Leon Woestenberg <leon@sidebranch.com>
---
 recipes/udev/acl_2.2.49.bb  |    2 ++
 recipes/udev/attr_2.4.44.bb |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/recipes/udev/acl_2.2.49.bb b/recipes/udev/acl_2.2.49.bb
index aeec494..027a8c6 100644
--- a/recipes/udev/acl_2.2.49.bb
+++ b/recipes/udev/acl_2.2.49.bb
@@ -30,6 +30,8 @@ do_install() {
     export PKG_MAN_DIR=${D}${mandir}
     export PKG_DOC_DIR=${D}${datadir}/doc/acl
     export PKG_LOCALE_DIR=${D}${datadir}/locale
+    # ensure the subdir Makefile do not use the (wrong) variable overrides from the include file
+    export MAKE="${MAKE} -e"
 
     oe_runmake -e install install-dev install-lib
 
diff --git a/recipes/udev/attr_2.4.44.bb b/recipes/udev/attr_2.4.44.bb
index ee48693..c2054d1 100644
--- a/recipes/udev/attr_2.4.44.bb
+++ b/recipes/udev/attr_2.4.44.bb
@@ -30,6 +30,8 @@ do_install() {
 	export PKG_MAN_DIR=${D}${mandir}
 	export PKG_DOC_DIR=${D}${datadir}/doc/attr
 	export PKG_LOCALE_DIR=${D}${datadir}/locale
+        # ensure the subdir Makefile do not use the (wrong) variable overrides from the include file
+        export MAKE="${MAKE} -e"
 
 	oe_runmake -e install install-dev install-lib
 
-- 
1.6.3.3

Re: [PATCH] udev/{acl, attr}: Fix install. Wanted to install to host /usr/bin/.

[Henri Bragge]

Leon Woestenberg wrote:
> The subdirectory Makefile includes a file, that overrides the
> variables inherited from the parent Makefile. Those where provided
> to the parent make through '-e'.
>
> Make sure the subdir makes also use '-e'.
>   

Works here!

Re: [PATCH] udev/{acl, attr}: Fix install. Wanted to install to host /usr/bin/.

[Khem Raj]

On Mon, Jun 14, 2010 at 1:12 PM, Leon Woestenberg
<leon.woestenberg@gmail.com> wrote:
> The subdirectory Makefile includes a file, that overrides the
> variables inherited from the parent Makefile. Those where provided
> to the parent make through '-e'.
>
> Make sure the subdir makes also use '-e'.
>
> (An alternative fix is to sed the include file.)
>
> Signed-off-by: Leon Woestenberg <leon@sidebranch.com>

Acked-by: Khem Raj <raj.khem@gmail.com>

> ---
>  recipes/udev/acl_2.2.49.bb  |    2 ++
>  recipes/udev/attr_2.4.44.bb |    2 ++
>  2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/recipes/udev/acl_2.2.49.bb b/recipes/udev/acl_2.2.49.bb
> index aeec494..027a8c6 100644
> --- a/recipes/udev/acl_2.2.49.bb
> +++ b/recipes/udev/acl_2.2.49.bb
> @@ -30,6 +30,8 @@ do_install() {
>     export PKG_MAN_DIR=${D}${mandir}
>     export PKG_DOC_DIR=${D}${datadir}/doc/acl
>     export PKG_LOCALE_DIR=${D}${datadir}/locale
> +    # ensure the subdir Makefile do not use the (wrong) variable overrides from the include file
> +    export MAKE="${MAKE} -e"
>
>     oe_runmake -e install install-dev install-lib
>
> diff --git a/recipes/udev/attr_2.4.44.bb b/recipes/udev/attr_2.4.44.bb
> index ee48693..c2054d1 100644
> --- a/recipes/udev/attr_2.4.44.bb
> +++ b/recipes/udev/attr_2.4.44.bb
> @@ -30,6 +30,8 @@ do_install() {
>        export PKG_MAN_DIR=${D}${mandir}
>        export PKG_DOC_DIR=${D}${datadir}/doc/attr
>        export PKG_LOCALE_DIR=${D}${datadir}/locale
> +        # ensure the subdir Makefile do not use the (wrong) variable overrides from the include file
> +        export MAKE="${MAKE} -e"
>
>        oe_runmake -e install install-dev install-lib
>
> --
> 1.6.3.3
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>