* [meta-browser][PATCH] nss: change shebang line for smime script
@ 2013-03-26 10:32 Laurentiu Palcu
2013-03-26 10:42 ` Koen Kooi
2013-03-26 11:11 ` [meta-browser][PATCH v2] " Laurentiu Palcu
0 siblings, 2 replies; 6+ messages in thread
From: Laurentiu Palcu @ 2013-03-26 10:32 UTC (permalink / raw)
To: openembedded-devel
This patch fixes the shebang line of the smime script and also adds a
'perl' RDEPENDS for the main package since smime needs perl to run.
Also, this patch fixes some do_rootfs failures when using RPM backend
because RPM automatically scans the files and, if perl scripts are
found, adds dependency on the file found in the shebang line (i.e.
/usr/local/bin/perl).
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
recipes-support/nss/nss_3.13.3.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/recipes-support/nss/nss_3.13.3.bb b/recipes-support/nss/nss_3.13.3.bb
index 59c16e8..c05179f 100644
--- a/recipes-support/nss/nss_3.13.3.bb
+++ b/recipes-support/nss/nss_3.13.3.bb
@@ -7,6 +7,7 @@ LICENSE = "MPL1.1 GPL LGPL"
LIC_FILES_CHKSUM = "file://security/nss/manifest.mn;md5=d71978748f23eae3156c38ac2a691924"
DEPENDS = "sqlite3 nspr nspr-native"
+RDEPENDS_${PN} += "perl"
SRC_URI = "\
http://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/NSS_3_13_3_RTM/src/${PN}-${PV}.tar.gz \
@@ -105,6 +106,8 @@ do_install() {
sed -i s:OELIBDIR:${libdir}:g ${D}${libdir}/pkgconfig/nss.pc
sed -i s:OEINCDIR:${includedir}:g ${D}${libdir}/pkgconfig/nss.pc
sed -i s:OEEXECPREFIX:${exec_prefix}:g ${D}${libdir}/pkgconfig/nss.pc
+
+ sed -i s:/usr/local/bin/perl:${bindir}/perl:g ${D}${bindir}/smime
}
FILES_SOLIBSDEV := ""
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-browser][PATCH] nss: change shebang line for smime script
2013-03-26 10:32 [meta-browser][PATCH] nss: change shebang line for smime script Laurentiu Palcu
@ 2013-03-26 10:42 ` Koen Kooi
2013-03-26 11:02 ` Laurentiu Palcu
2013-03-26 11:11 ` [meta-browser][PATCH v2] " Laurentiu Palcu
1 sibling, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2013-03-26 10:42 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 26-03-13 11:32, Laurentiu Palcu schreef:
> This patch fixes the shebang line of the smime script and also adds a
> 'perl' RDEPENDS for the main package since smime needs perl to run.
>
> Also, this patch fixes some do_rootfs failures when using RPM backend
> because RPM automatically scans the files and, if perl scripts are found,
> adds dependency on the file found in the shebang line (i.e.
> /usr/local/bin/perl).
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> ---
> recipes-support/nss/nss_3.13.3.bb | 3 +++ 1 file changed, 3
> insertions(+)
>
> diff --git a/recipes-support/nss/nss_3.13.3.bb
> b/recipes-support/nss/nss_3.13.3.bb index 59c16e8..c05179f 100644 ---
> a/recipes-support/nss/nss_3.13.3.bb +++
> b/recipes-support/nss/nss_3.13.3.bb @@ -7,6 +7,7 @@ LICENSE = "MPL1.1 GPL
> LGPL" LIC_FILES_CHKSUM =
> "file://security/nss/manifest.mn;md5=d71978748f23eae3156c38ac2a691924"
>
> DEPENDS = "sqlite3 nspr nspr-native" +RDEPENDS_${PN} += "perl"
R* variables are grouped with below do_install since the OE style guide
tends to group variables into the order the tasks are executed. So RDEPENDS
and friends go below do_install next to FILES_*
>
> SRC_URI = "\
> http://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/NSS_3_13_3_RTM/src/${PN}-${PV}.tar.gz
> \ @@ -105,6 +106,8 @@ do_install() { sed -i s:OELIBDIR:${libdir}:g
> ${D}${libdir}/pkgconfig/nss.pc sed -i s:OEINCDIR:${includedir}:g
> ${D}${libdir}/pkgconfig/nss.pc sed -i s:OEEXECPREFIX:${exec_prefix}:g
> ${D}${libdir}/pkgconfig/nss.pc + + sed -i
> s:/usr/local/bin/perl:${bindir}/perl:g ${D}${bindir}/smime }
>
> FILES_SOLIBSDEV := ""
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org
iD8DBQFRUXuNMkyGM64RGpERAkwBAJoC3D1MJRVys1x7mMOJJYKRldACmgCfRz4J
K/jWMy6Ni5/K8wXHpS9rbWU=
=T5Sy
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-browser][PATCH] nss: change shebang line for smime script
2013-03-26 10:42 ` Koen Kooi
@ 2013-03-26 11:02 ` Laurentiu Palcu
0 siblings, 0 replies; 6+ messages in thread
From: Laurentiu Palcu @ 2013-03-26 11:02 UTC (permalink / raw)
To: openembedded-devel
On 03/26/2013 12:42 PM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 26-03-13 11:32, Laurentiu Palcu schreef:
>> This patch fixes the shebang line of the smime script and also adds a
>> 'perl' RDEPENDS for the main package since smime needs perl to run.
>>
>> Also, this patch fixes some do_rootfs failures when using RPM backend
>> because RPM automatically scans the files and, if perl scripts are found,
>> adds dependency on the file found in the shebang line (i.e.
>> /usr/local/bin/perl).
>>
>> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com> ---
>> recipes-support/nss/nss_3.13.3.bb | 3 +++ 1 file changed, 3
>> insertions(+)
>>
>> diff --git a/recipes-support/nss/nss_3.13.3.bb
>> b/recipes-support/nss/nss_3.13.3.bb index 59c16e8..c05179f 100644 ---
>> a/recipes-support/nss/nss_3.13.3.bb +++
>> b/recipes-support/nss/nss_3.13.3.bb @@ -7,6 +7,7 @@ LICENSE = "MPL1.1 GPL
>> LGPL" LIC_FILES_CHKSUM =
>> "file://security/nss/manifest.mn;md5=d71978748f23eae3156c38ac2a691924"
>>
>> DEPENDS = "sqlite3 nspr nspr-native" +RDEPENDS_${PN} += "perl"
>
> R* variables are grouped with below do_install since the OE style guide
> tends to group variables into the order the tasks are executed. So RDEPENDS
> and friends go below do_install next to FILES_*
OK, I knew there was a rule about where these variables should go but I
didn't check it again... I will resend the patch. Thanks for brining it up.
However, I did google it just now out of curiosity (and to refresh my
memory) and found 2 different pages with different rules:
http://www.openembedded.org/wiki/Styleguide
https://wiki.yoctoproject.org/wiki/Recipe_%26_Patch_Style_Guide
I'll go with the yocto wiki since is newer than the openembedded one but
I believe these 2 should be in sync.
Thanks,
Laurentiu
>
>>
>> SRC_URI = "\
>> http://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/NSS_3_13_3_RTM/src/${PN}-${PV}.tar.gz
>> \ @@ -105,6 +106,8 @@ do_install() { sed -i s:OELIBDIR:${libdir}:g
>> ${D}${libdir}/pkgconfig/nss.pc sed -i s:OEINCDIR:${includedir}:g
>> ${D}${libdir}/pkgconfig/nss.pc sed -i s:OEEXECPREFIX:${exec_prefix}:g
>> ${D}${libdir}/pkgconfig/nss.pc + + sed -i
>> s:/usr/local/bin/perl:${bindir}/perl:g ${D}${bindir}/smime }
>>
>> FILES_SOLIBSDEV := ""
>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFRUXuNMkyGM64RGpERAkwBAJoC3D1MJRVys1x7mMOJJYKRldACmgCfRz4J
> K/jWMy6Ni5/K8wXHpS9rbWU=
> =T5Sy
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [meta-browser][PATCH v2] nss: change shebang line for smime script
2013-03-26 10:32 [meta-browser][PATCH] nss: change shebang line for smime script Laurentiu Palcu
2013-03-26 10:42 ` Koen Kooi
@ 2013-03-26 11:11 ` Laurentiu Palcu
2013-04-29 6:51 ` Laurentiu Palcu
1 sibling, 1 reply; 6+ messages in thread
From: Laurentiu Palcu @ 2013-03-26 11:11 UTC (permalink / raw)
To: openembedded-devel
This patch fixes the shebang line of the smime script and also adds a
'perl' RDEPENDS for the main package since smime needs perl to run.
Also, this patch fixes some do_rootfs failures when using RPM backend
because RPM automatically scans the files and, if perl scripts are
found, adds dependency on the file found in the shebang line (i.e.
/usr/local/bin/perl).
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
Changes in v2:
* moved the RDEPENDS line at the end to conform with the style guide;
Thanks,
Laurentiu
recipes-support/nss/nss_3.13.3.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/recipes-support/nss/nss_3.13.3.bb b/recipes-support/nss/nss_3.13.3.bb
index 59c16e8..fbab6ee 100644
--- a/recipes-support/nss/nss_3.13.3.bb
+++ b/recipes-support/nss/nss_3.13.3.bb
@@ -105,7 +105,10 @@ do_install() {
sed -i s:OELIBDIR:${libdir}:g ${D}${libdir}/pkgconfig/nss.pc
sed -i s:OEINCDIR:${includedir}:g ${D}${libdir}/pkgconfig/nss.pc
sed -i s:OEEXECPREFIX:${exec_prefix}:g ${D}${libdir}/pkgconfig/nss.pc
+
+ sed -i s:/usr/local/bin/perl:${bindir}/perl:g ${D}${bindir}/smime
}
FILES_SOLIBSDEV := ""
FILES_${PN} += "${base_libdir}/lib*${SOLIBSDEV} ${libdir}/lib*${SOLIBSDEV}"
+RDEPENDS_${PN} += "perl"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-browser][PATCH v2] nss: change shebang line for smime script
2013-03-26 11:11 ` [meta-browser][PATCH v2] " Laurentiu Palcu
@ 2013-04-29 6:51 ` Laurentiu Palcu
2013-04-29 7:05 ` Eric Bénard
0 siblings, 1 reply; 6+ messages in thread
From: Laurentiu Palcu @ 2013-04-29 6:51 UTC (permalink / raw)
To: openembedded-devel; +Cc: otavio
Ping!
On 03/26/2013 01:11 PM, Laurentiu Palcu wrote:
> This patch fixes the shebang line of the smime script and also adds a
> 'perl' RDEPENDS for the main package since smime needs perl to run.
>
> Also, this patch fixes some do_rootfs failures when using RPM backend
> because RPM automatically scans the files and, if perl scripts are
> found, adds dependency on the file found in the shebang line (i.e.
> /usr/local/bin/perl).
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> ---
> Changes in v2:
> * moved the RDEPENDS line at the end to conform with the style guide;
>
> Thanks,
> Laurentiu
>
> recipes-support/nss/nss_3.13.3.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/recipes-support/nss/nss_3.13.3.bb b/recipes-support/nss/nss_3.13.3.bb
> index 59c16e8..fbab6ee 100644
> --- a/recipes-support/nss/nss_3.13.3.bb
> +++ b/recipes-support/nss/nss_3.13.3.bb
> @@ -105,7 +105,10 @@ do_install() {
> sed -i s:OELIBDIR:${libdir}:g ${D}${libdir}/pkgconfig/nss.pc
> sed -i s:OEINCDIR:${includedir}:g ${D}${libdir}/pkgconfig/nss.pc
> sed -i s:OEEXECPREFIX:${exec_prefix}:g ${D}${libdir}/pkgconfig/nss.pc
> +
> + sed -i s:/usr/local/bin/perl:${bindir}/perl:g ${D}${bindir}/smime
> }
>
> FILES_SOLIBSDEV := ""
> FILES_${PN} += "${base_libdir}/lib*${SOLIBSDEV} ${libdir}/lib*${SOLIBSDEV}"
> +RDEPENDS_${PN} += "perl"
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-browser][PATCH v2] nss: change shebang line for smime script
2013-04-29 6:51 ` Laurentiu Palcu
@ 2013-04-29 7:05 ` Eric Bénard
0 siblings, 0 replies; 6+ messages in thread
From: Eric Bénard @ 2013-04-29 7:05 UTC (permalink / raw)
To: laurentiu.palcu; +Cc: openembedded-devel, otavio
Hi Laurentiu,
Le Mon, 29 Apr 2013 09:51:58 +0300,
Laurentiu Palcu <laurentiu.palcu@intel.com> a écrit :
> Ping!
>
> On 03/26/2013 01:11 PM, Laurentiu Palcu wrote:
> > This patch fixes the shebang line of the smime script and also adds a
> > 'perl' RDEPENDS for the main package since smime needs perl to run.
> >
> > Also, this patch fixes some do_rootfs failures when using RPM backend
> > because RPM automatically scans the files and, if perl scripts are
> > found, adds dependency on the file found in the shebang line (i.e.
> > /usr/local/bin/perl).
> >
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> > ---
> > Changes in v2:
> > * moved the RDEPENDS line at the end to conform with the style guide;
> >
pushed to master & dylan.
Thanks,
Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-29 7:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 10:32 [meta-browser][PATCH] nss: change shebang line for smime script Laurentiu Palcu
2013-03-26 10:42 ` Koen Kooi
2013-03-26 11:02 ` Laurentiu Palcu
2013-03-26 11:11 ` [meta-browser][PATCH v2] " Laurentiu Palcu
2013-04-29 6:51 ` Laurentiu Palcu
2013-04-29 7:05 ` Eric Bénard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox